From: "Lee Marlow" <lee.marlow@gmail.com>
To: "Giuseppe Bilotta" <giuseppe.bilotta@gmail.com>
Cc: "Kevin Ballard" <kevin@sb.org>,
"Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] diff: add ruby funcname pattern
Date: Sat, 2 Aug 2008 09:37:14 -0600 [thread overview]
Message-ID: <7968d7490808020837m57a7c48fjf40c0a715f7f39ce@mail.gmail.com> (raw)
In-Reply-To: <C871A30D-F2AF-4385-ABD4-C57F474D7F01@sb.org>
On Fri, Aug 1, 2008 at 11:47 PM, Kevin Ballard <kevin@sb.org> wrote:
> On Aug 1, 2008, at 10:41 PM, Giuseppe Bilotta wrote:
>
>> On Sat, Aug 2, 2008 at 2:31 AM, Kevin Ballard <kevin@sb.org> wrote:
>
> I think it's far simpler to stick with class/module/def.
>
I agree with Kevin.
It's simpler and I'm not sure what value it would bring to show
anonymous code blocks. The funcname is just to provide some
additional context around the diff hunk, so you know where you are.
What would be shown for an anonymous code block or proc in the diff?
The module/class/method seems to provide the most useful context.
-Lee
prev parent reply other threads:[~2008-08-02 15:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 7:21 [PATCH] diff: add ruby funcname pattern Giuseppe Bilotta
2008-08-01 7:30 ` Junio C Hamano
2008-08-01 8:11 ` Giuseppe Bilotta
2008-08-01 8:20 ` Junio C Hamano
2008-08-01 8:39 ` Giuseppe Bilotta
2008-08-01 14:41 ` Jeff King
2008-08-02 0:31 ` Kevin Ballard
2008-08-02 3:50 ` Junio C Hamano
2008-08-02 5:41 ` Giuseppe Bilotta
2008-08-02 5:47 ` Kevin Ballard
2008-08-02 6:06 ` Giuseppe Bilotta
2008-08-02 11:39 ` Johannes Schindelin
2008-08-02 11:50 ` Giuseppe Bilotta
2008-08-02 15:37 ` Lee Marlow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7968d7490808020837m57a7c48fjf40c0a715f7f39ce@mail.gmail.com \
--to=lee.marlow@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
--cc=kevin@sb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).