From: Thomas Rast <trast@student.ethz.ch>
To: <git@vger.kernel.org>
Cc: Stephen Boyd <bebarino@gmail.com>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 2/4] t4014: invoke format-patch with --stdout where intended
Date: Mon, 29 Aug 2011 22:10:47 +0200 [thread overview]
Message-ID: <797b96d784211a9d26eac1a5f5f7f0388a2c6a3b.1314648438.git.trast@student.ethz.ch> (raw)
In-Reply-To: <bbfb7190ca0125798417f57f4d33b5443257e478.1314648438.git.trast@student.ethz.ch>
The test wrote something along the lines of 0001-foo.patch to output,
which of course never contained a signature. Luckily the tested
behaviour is actually present.
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---
t/t4014-format-patch.sh | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
index b4d4207..a45d4fb 100755
--- a/t/t4014-format-patch.sh
+++ b/t/t4014-format-patch.sh
@@ -698,8 +698,8 @@ test_expect_success 'format-patch --no-signature supresses signatures' '
! grep "^-- \$" output
'
-test_expect_failure 'format-patch --signature="" supresses signatures' '
- git format-patch --signature="" -1 >output &&
+test_expect_success 'format-patch --signature="" supresses signatures' '
+ git format-patch --stdout --signature="" -1 >output &&
check_patch output &&
! grep "^-- \$" output
'
--
1.7.7.rc0.370.gdcae57
next prev parent reply other threads:[~2011-08-29 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 20:10 [PATCH 1/4] t4014: check for empty files from git format-patch --stdout Thomas Rast
2011-08-29 20:10 ` Thomas Rast [this message]
2011-08-29 20:10 ` [PATCH 3/4] t4014: "no-add-headers" is actually called "no-add-header" Thomas Rast
2011-08-29 20:10 ` [PATCH 4/4] Document negated forms of format-patch --to --cc --add-headers Thomas Rast
2011-08-29 22:30 ` [PATCH 1/4] t4014: check for empty files from git format-patch --stdout Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=797b96d784211a9d26eac1a5f5f7f0388a2c6a3b.1314648438.git.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).