* [PATCH] t4202: fix patternType setting in --invert-grep test
@ 2021-12-17 16:48 René Scharfe
2021-12-18 0:14 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: René Scharfe @ 2021-12-17 16:48 UTC (permalink / raw)
To: Git List; +Cc: Junio C Hamano, Ævar Arnfjörð Bjarmason
Actually use extended regexes as indicated in the comment.
Signed-off-by: René Scharfe <l.s.r@web.de>
---
t/t4202-log.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t4202-log.sh b/t/t4202-log.sh
index 7884e3d46b..f51b57b4a2 100755
--- a/t/t4202-log.sh
+++ b/t/t4202-log.sh
@@ -250,7 +250,7 @@ test_expect_success 'log --invert-grep --grep' '
test_cmp expect actual &&
# POSIX extended
- git -c grep.patternType=basic log --pretty="tformat:%s" --invert-grep --grep=t[h] --grep=S[e]c >actual &&
+ git -c grep.patternType=extended log --pretty="tformat:%s" --invert-grep --grep=t[h] --grep=S[e]c >actual &&
test_cmp expect actual &&
# PCRE
--
2.34.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] t4202: fix patternType setting in --invert-grep test
2021-12-17 16:48 [PATCH] t4202: fix patternType setting in --invert-grep test René Scharfe
@ 2021-12-18 0:14 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2021-12-18 0:14 UTC (permalink / raw)
To: René Scharfe; +Cc: Git List, Ævar Arnfjörð Bjarmason
René Scharfe <l.s.r@web.de> writes:
> Actually use extended regexes as indicated in the comment.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> t/t4202-log.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t4202-log.sh b/t/t4202-log.sh
> index 7884e3d46b..f51b57b4a2 100755
> --- a/t/t4202-log.sh
> +++ b/t/t4202-log.sh
> @@ -250,7 +250,7 @@ test_expect_success 'log --invert-grep --grep' '
> test_cmp expect actual &&
>
> # POSIX extended
> - git -c grep.patternType=basic log --pretty="tformat:%s" --invert-grep --grep=t[h] --grep=S[e]c >actual &&
> + git -c grep.patternType=extended log --pretty="tformat:%s" --invert-grep --grep=t[h] --grep=S[e]c >actual &&
> test_cmp expect actual &&
Good eyes.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-18 0:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-17 16:48 [PATCH] t4202: fix patternType setting in --invert-grep test René Scharfe
2021-12-18 0:14 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).