git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Git Users <git@vger.kernel.org>
Subject: git status when merging non-conflicted 3-way merge says "All conflicts fixed"
Date: Tue, 25 May 2021 14:03:56 +0700	[thread overview]
Message-ID: <79e26cee-daed-d52b-76d7-692f5cb2e20a@gmail.com> (raw)

Hi,

Supposed that we have following commit graph:

----A----B----C----D <- master
               \
                ----E <- e

When we merge e branch by `git merge e`, obviously we will do 3-way
merge. Assumed that the merge doesn't conflict, Git will fire up
editor to edit `COMMIT_EDITMSG` for us to enter merge commit
message. Then we abort the commit by either delete all the lines
there, or comment all of them.

But when we check status by `git status`, Git says:

> On branch master
> All conflicts fixed but you are still merging.
>   (use "git commit" to conclude merge)

That message above is misleading, because we know that our merge
doesn't conflict (3-way merge applied successfully without conflict). 
However, it makes sense only when we have resolved all conflicts
on the conflicted merge.

So for non-conflicted merge, we can say instead:

> On branch <branch>
> You are still merging, and the merge applied without any conflicts.
>   (use "git commit" to conclude merge)

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

             reply	other threads:[~2021-05-25  7:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25  7:03 Bagas Sanjaya [this message]
2021-05-26 14:30 ` git status when merging non-conflicted 3-way merge says "All conflicts fixed" Elijah Newren
2021-05-26 15:13   ` Phillip Wood
2021-05-26 16:07     ` Elijah Newren
2021-05-26 22:54       ` Junio C Hamano
2021-05-26 16:06   ` Igor Djordjevic
2021-05-26 16:08     ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79e26cee-daed-d52b-76d7-692f5cb2e20a@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).