From: "Imran M Yousuf" <imyousuf@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Simplified the invocation of command action in submodule
Date: Wed, 9 Jan 2008 14:23:51 +0600 [thread overview]
Message-ID: <7bfdc29a0801090023s437b681ak435f4e31ee649b72@mail.gmail.com> (raw)
In-Reply-To: <7vsl17l8bi.fsf@gitster.siamese.dyndns.org>
Hi Junio,
Firstly, $add is still used later in the code.
Secondly, yes the variables should be deleted. Will make the change
and send the patch again; I forgot to clean the unused variables from
the declaration, sorry.
Best regards,
Imran
On Jan 9, 2008 2:19 PM, Junio C Hamano <gitster@pobox.com> wrote:
> imyousuf@gmail.com writes:
>
> > diff --git a/git-submodule.sh b/git-submodule.sh
> > index ad9fe62..8a29382 100755
> > --- a/git-submodule.sh
> > +++ b/git-submodule.sh
> > @@ -16,6 +16,7 @@ update=
> > status=
> > quiet=
> > cached=
> > +command=
>
> Doesn't the patch make some if not all of the above variables
> unused?
>
> > case "$1" in
> > add)
> > add=1
> > + command="module_$1"
> > ;;
> > init)
> > - init=1
> > + command="modules_$1"
> > ;;
>
> Does the remaining code still use $add?
>
--
Imran M Yousuf
next prev parent reply other threads:[~2008-01-09 8:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 3:59 [PATCH] Simplified the invocation of command action in submodule imyousuf
2008-01-09 8:19 ` Junio C Hamano
2008-01-09 8:23 ` Imran M Yousuf [this message]
2008-01-09 8:59 ` Johannes Sixt
2008-01-09 9:07 ` Imran M Yousuf
2008-01-09 9:15 ` Johannes Sixt
2008-01-09 9:51 ` Imran M Yousuf
2008-01-09 10:01 ` Johannes Sixt
2008-01-09 10:06 ` Imran M Yousuf
2008-01-09 10:27 ` Junio C Hamano
2008-01-09 10:24 ` Lars Hjemli
2008-01-10 3:05 ` Imran M Yousuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bfdc29a0801090023s437b681ak435f4e31ee649b72@mail.gmail.com \
--to=imyousuf@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).