[JGIT RFC] JGit mavenization done right

[JGIT RFC] JGit mavenization done right

[Imran M Yousuf]

Hi,

Firstly I would like to apologize for taking so long to get it right,
could not get enough time :(. As of now the mavenized version of jgit
uses the same codebase and resources of that of the original JGit.
With modifications in resources location - previously resources were
being read from the current working directory and now from classpath.
Moved the location just to separate code and reources.

I would like to request you all to test out JGit from
http://repo.or.cz/w/egit/imyousuf.git. Please checkout the branch
'unified_tst_rsrc' and try to build it with both maven and Eclipse
(i.e. as was built earlier) and please be kind enough to inform me if
the build fails. Please feel free to suggest any improvements you have
in mind.

If it is okayed I will improve it further to configure various test
report and maven site plugin to host the summary of project.

Thank you and Best regards,

-- 
Imran M Yousuf
Email: imran@smartitengineering.com
Blog: http://imyousuf-tech.blogs.smartitengineering.com/
Mobile: +880-1711402557

Re: [JGIT RFC] JGit mavenization done right

[Shawn O. Pearce]

Imran M Yousuf <imyousuf@gmail.com> wrote:
> I would like to request you all to test out JGit from
> http://repo.or.cz/w/egit/imyousuf.git. Please checkout the branch
> 'unified_tst_rsrc' and try to build it with both maven and Eclipse
> (i.e. as was built earlier) and please be kind enough to inform me if
> the build fails. Please feel free to suggest any improvements you have
> in mind.

Thanks, I'll take a look at it tomorrow or the day after.

I am looking forward to making JGit more available to the Java
community, so support under Maven is welcome, even if Maven isn't
the project's (current) primary build tool.
 
-- 
Shawn.

Re: [JGIT RFC] JGit mavenization done right

[Imran M Yousuf]

On Mon, Aug 18, 2008 at 11:55 AM, Shawn O. Pearce <spearce@spearce.org> wrote:
> Imran M Yousuf <imyousuf@gmail.com> wrote:
>> I would like to request you all to test out JGit from
>> http://repo.or.cz/w/egit/imyousuf.git. Please checkout the branch
>> 'unified_tst_rsrc' and try to build it with both maven and Eclipse
>> (i.e. as was built earlier) and please be kind enough to inform me if
>> the build fails. Please feel free to suggest any improvements you have
>> in mind.
>
> Thanks, I'll take a look at it tomorrow or the day after.

Thanks, it would nice to know whether it works in the original build
process or not :).

>
> I am looking forward to making JGit more available to the Java
> community, so support under Maven is welcome, even if Maven isn't
> the project's (current) primary build tool.

Once this is out of the way I will add configuration to make the
source code and other project related information to be allowed to be
published online from maven POM file using the 'site' plugin.

Additionally I also want to add configuration to build a distribution
for JGit PGM project.

>
> --
> Shawn.

Best regards,

-- 
Imran M Yousuf
Email: imran@smartitengineering.com
Blog: http://imyousuf-tech.blogs.smartitengineering.com/
Mobile: +880-1711402557

Re: [JGIT RFC] JGit mavenization done right

[Shawn O. Pearce]

Imran M Yousuf <imyousuf@gmail.com> wrote:
> On Mon, Aug 18, 2008 at 11:55 AM, Shawn O. Pearce <spearce@spearce.org> wrote:
> > Imran M Yousuf <imyousuf@gmail.com> wrote:
> >> I would like to request you all to test out JGit from
> >> http://repo.or.cz/w/egit/imyousuf.git. Please checkout the branch
> >> 'unified_tst_rsrc' and try to build it with both maven and Eclipse
> >> (i.e. as was built earlier)
> 
> Thanks, it would nice to know whether it works in the original build
> process or not :).

Well, it did break it in Eclipse:

$ git diff-tree --abbrev -r -M --diff-filter=D orcz-pub/master HEAD
:100644 000000 9d7d138... 0000000... D  org.spearce.jgit.test/.gitignore
:100644 000000 987d6be... 0000000... D  org.spearce.jgit.test/.project
:100644 000000 8bfa5f1... 0000000... D  org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs
:100644 000000 fce94cf... 0000000... D  org.spearce.jgit.test/.settings/org.eclipse.jdt.ui.prefs
:100644 000000 304e861... 0000000... D  org.spearce.jgit/.classpath
:100644 000000 ba077a4... 0000000... D  org.spearce.jgit/.gitignore
:100644 000000 7d38455... 0000000... D  org.spearce.jgit/.project
:100644 000000 709a440... 0000000... D  org.spearce.jgit/.settings/org.eclipse.jdt.ui.prefs

Removing this stuff was not so good.  The Eclipse projects are
busted and can't be used anymore.  We need them back.

The make_jgit.sh however seems to produce a valid JAR.  Given the
file-level differences I didn't expect it to fail.

Also, I wonder if JGitTestUtil is better handled by placing the
method in RepositoryTestCase and making sure everyone subclasses
that if they need a test resource file?  I'm fairly certain they
already do, and its a lot easier to invoke a method you inherited
than one in another class.  (Well, easier for the guy writing the
test case anyway, Java obviously doesn't care either way.)

If we are going to take this in upstream I'd like a flattened/cleaned
up history.  Being able to bisect the misstep of using symlinks
(the old Maven approach) isn't very valuable in the long-term view
of the history.

Robin, any thoughts?
 
-- 
Shawn.

Re: [JGIT RFC] JGit mavenization done right

[Robin Rosenberg]

tisdagen den 19 augusti 2008 16.44.24 skrev Shawn O. Pearce:
> Imran M Yousuf <imyousuf@gmail.com> wrote:
> > On Mon, Aug 18, 2008 at 11:55 AM, Shawn O. Pearce <spearce@spearce.org> wrote:
> > > Imran M Yousuf <imyousuf@gmail.com> wrote:
> > >> I would like to request you all to test out JGit from
> > >> http://repo.or.cz/w/egit/imyousuf.git. Please checkout the branch
> > >> 'unified_tst_rsrc' and try to build it with both maven and Eclipse
> > >> (i.e. as was built earlier)
> > 
> > Thanks, it would nice to know whether it works in the original build
> > process or not :).
> 
> Well, it did break it in Eclipse:
> 
> $ git diff-tree --abbrev -r -M --diff-filter=D orcz-pub/master HEAD
> :100644 000000 9d7d138... 0000000... D  org.spearce.jgit.test/.gitignore
> :100644 000000 987d6be... 0000000... D  org.spearce.jgit.test/.project
> :100644 000000 8bfa5f1... 0000000... D  org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs
> :100644 000000 fce94cf... 0000000... D  org.spearce.jgit.test/.settings/org.eclipse.jdt.ui.prefs
> :100644 000000 304e861... 0000000... D  org.spearce.jgit/.classpath
> :100644 000000 ba077a4... 0000000... D  org.spearce.jgit/.gitignore
> :100644 000000 7d38455... 0000000... D  org.spearce.jgit/.project
> :100644 000000 709a440... 0000000... D  org.spearce.jgit/.settings/org.eclipse.jdt.ui.prefs
> 
> Removing this stuff was not so good.  The Eclipse projects are
> busted and can't be used anymore.  We need them back.
> 
> The make_jgit.sh however seems to produce a valid JAR.  Given the
> file-level differences I didn't expect it to fail.
> 
> Also, I wonder if JGitTestUtil is better handled by placing the
> method in RepositoryTestCase and making sure everyone subclasses
> that if they need a test resource file?  I'm fairly certain they
> already do, and its a lot easier to invoke a method you inherited
> than one in another class.  (Well, easier for the guy writing the
> test case anyway, Java obviously doesn't care either way.)
> 
> If we are going to take this in upstream I'd like a flattened/cleaned
> up history.  Being able to bisect the misstep of using symlinks
> (the old Maven approach) isn't very valuable in the long-term view
> of the history.
> 
> Robin, any thoughts?

Right, I'd also like to see that cleaned up approch in patch form. Cleaning up
helps when preparing for review because one usually find bad stuff during
that process.

-- robin

Re: [JGIT RFC] JGit mavenization done right

[Imran M Yousuf]

On Wed, Aug 20, 2008 at 1:52 AM, Robin Rosenberg
<robin.rosenberg.lists@dewire.com> wrote:
> tisdagen den 19 augusti 2008 16.44.24 skrev Shawn O. Pearce:
>> Imran M Yousuf <imyousuf@gmail.com> wrote:
>> > On Mon, Aug 18, 2008 at 11:55 AM, Shawn O. Pearce <spearce@spearce.org> wrote:
>> > > Imran M Yousuf <imyousuf@gmail.com> wrote:
>> > >> I would like to request you all to test out JGit from
>> > >> http://repo.or.cz/w/egit/imyousuf.git. Please checkout the branch
>> > >> 'unified_tst_rsrc' and try to build it with both maven and Eclipse
>> > >> (i.e. as was built earlier)
>> >
>> > Thanks, it would nice to know whether it works in the original build
>> > process or not :).
>>
>> Well, it did break it in Eclipse:
>>
>> $ git diff-tree --abbrev -r -M --diff-filter=D orcz-pub/master HEAD
>> :100644 000000 9d7d138... 0000000... D  org.spearce.jgit.test/.gitignore
>> :100644 000000 987d6be... 0000000... D  org.spearce.jgit.test/.project
>> :100644 000000 8bfa5f1... 0000000... D  org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs
>> :100644 000000 fce94cf... 0000000... D  org.spearce.jgit.test/.settings/org.eclipse.jdt.ui.prefs
>> :100644 000000 304e861... 0000000... D  org.spearce.jgit/.classpath
>> :100644 000000 ba077a4... 0000000... D  org.spearce.jgit/.gitignore
>> :100644 000000 7d38455... 0000000... D  org.spearce.jgit/.project
>> :100644 000000 709a440... 0000000... D  org.spearce.jgit/.settings/org.eclipse.jdt.ui.prefs
>>
>> Removing this stuff was not so good.  The Eclipse projects are
>> busted and can't be used anymore.  We need them back.
>>
>> The make_jgit.sh however seems to produce a valid JAR.  Given the
>> file-level differences I didn't expect it to fail.
>>
>> Also, I wonder if JGitTestUtil is better handled by placing the
>> method in RepositoryTestCase and making sure everyone subclasses
>> that if they need a test resource file?  I'm fairly certain they
>> already do, and its a lot easier to invoke a method you inherited
>> than one in another class.  (Well, easier for the guy writing the
>> test case anyway, Java obviously doesn't care either way.)

In a true OOP sense a util class seemed a more valid approach to me. I
usually prefer to inherit staffs that are actually part of the object,
what I can do is have a base class method invoking the util, that will
not harm me :).

>>
>> If we are going to take this in upstream I'd like a flattened/cleaned
>> up history.  Being able to bisect the misstep of using symlinks
>> (the old Maven approach) isn't very valuable in the long-term view
>> of the history.
>>
>> Robin, any thoughts?
>
> Right, I'd also like to see that cleaned up approch in patch form. Cleaning up
> helps when preparing for review because one usually find bad stuff during
> that process.

I agree with the cleaned up approach I will redo it afresh by tonight
or day after tomorrow and create patches and resubmit it.

Thanks,

Imran

>
> -- robin
>



-- 
Imran M Yousuf
Entrepreneur & Software Engineer
Smart IT Engineering
Dhaka, Bangladesh
Email: imran@smartitengineering.com
Blog: http://imyousuf-tech.blogs.smartitengineering.com/
Mobile: +880-1711402557