From: "Imran M Yousuf" <imyousuf@gmail.com>
To: "Robin Rosenberg" <robin.rosenberg@dewire.com>
Cc: spearce@spearce.org, git@vger.kernel.org
Subject: Re: [JGIT PATCH] Force maven build to assume UTF-8 encoded source files
Date: Tue, 9 Sep 2008 08:05:19 +0600 [thread overview]
Message-ID: <7bfdc29a0809081905o30951d93lb8005f75d31b6002@mail.gmail.com> (raw)
In-Reply-To: <1220903169-15190-1-git-send-email-robin.rosenberg@dewire.com>
On Tue, Sep 9, 2008 at 1:46 AM, Robin Rosenberg
<robin.rosenberg@dewire.com> wrote:
> Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
> ---
> jgit-maven/jgit/pom.xml | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> We had one unit test failing because of this.
>
Firstly thanks for the change, secondly sorry for the inconvenience.
Thirdly, I could not detect the issue because the tests were passing
in my end from Eclipse and Maven :(. Sorry and thanks once again.
Cheers,
Imran
> -- robin
>
> diff --git a/jgit-maven/jgit/pom.xml b/jgit-maven/jgit/pom.xml
> index fe9b0c5..8ea56ca 100644
> --- a/jgit-maven/jgit/pom.xml
> +++ b/jgit-maven/jgit/pom.xml
> @@ -155,6 +155,7 @@ ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> + <encoding>UTF-8</encoding>
> </configuration>
> </plugin>
> </plugins>
> --
> 1.6.0.1.267.gec3a
>
>
--
Imran M Yousuf
Email: imran@smartitengineering.com
Blog: http://imyousuf-tech.blogs.smartitengineering.com/
Mobile: +880-1711402557
prev parent reply other threads:[~2008-09-09 2:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 19:46 [JGIT PATCH] Force maven build to assume UTF-8 encoded source files Robin Rosenberg
2008-09-09 2:05 ` Imran M Yousuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bfdc29a0809081905o30951d93lb8005f75d31b6002@mail.gmail.com \
--to=imyousuf@gmail.com \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).