* [JGIT PATCH] Force maven build to assume UTF-8 encoded source files
@ 2008-09-08 19:46 Robin Rosenberg
2008-09-09 2:05 ` Imran M Yousuf
0 siblings, 1 reply; 2+ messages in thread
From: Robin Rosenberg @ 2008-09-08 19:46 UTC (permalink / raw)
To: spearce; +Cc: imyousuf, git, Robin Rosenberg
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
---
jgit-maven/jgit/pom.xml | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
We had one unit test failing because of this.
-- robin
diff --git a/jgit-maven/jgit/pom.xml b/jgit-maven/jgit/pom.xml
index fe9b0c5..8ea56ca 100644
--- a/jgit-maven/jgit/pom.xml
+++ b/jgit-maven/jgit/pom.xml
@@ -155,6 +155,7 @@ ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
<configuration>
<source>1.5</source>
<target>1.5</target>
+ <encoding>UTF-8</encoding>
</configuration>
</plugin>
</plugins>
--
1.6.0.1.267.gec3a
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [JGIT PATCH] Force maven build to assume UTF-8 encoded source files
2008-09-08 19:46 [JGIT PATCH] Force maven build to assume UTF-8 encoded source files Robin Rosenberg
@ 2008-09-09 2:05 ` Imran M Yousuf
0 siblings, 0 replies; 2+ messages in thread
From: Imran M Yousuf @ 2008-09-09 2:05 UTC (permalink / raw)
To: Robin Rosenberg; +Cc: spearce, git
On Tue, Sep 9, 2008 at 1:46 AM, Robin Rosenberg
<robin.rosenberg@dewire.com> wrote:
> Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
> ---
> jgit-maven/jgit/pom.xml | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> We had one unit test failing because of this.
>
Firstly thanks for the change, secondly sorry for the inconvenience.
Thirdly, I could not detect the issue because the tests were passing
in my end from Eclipse and Maven :(. Sorry and thanks once again.
Cheers,
Imran
> -- robin
>
> diff --git a/jgit-maven/jgit/pom.xml b/jgit-maven/jgit/pom.xml
> index fe9b0c5..8ea56ca 100644
> --- a/jgit-maven/jgit/pom.xml
> +++ b/jgit-maven/jgit/pom.xml
> @@ -155,6 +155,7 @@ ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> + <encoding>UTF-8</encoding>
> </configuration>
> </plugin>
> </plugins>
> --
> 1.6.0.1.267.gec3a
>
>
--
Imran M Yousuf
Email: imran@smartitengineering.com
Blog: http://imyousuf-tech.blogs.smartitengineering.com/
Mobile: +880-1711402557
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-09 2:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-08 19:46 [JGIT PATCH] Force maven build to assume UTF-8 encoded source files Robin Rosenberg
2008-09-09 2:05 ` Imran M Yousuf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).