git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Jeff Hostetler <jeffhost@microsoft.com>,
	Jeff Hostetler <jeffhost@microsoft.com>
Subject: [PATCH 1/2] builtin/merge-file: fix compiler error on MacOS with clang 11.0.0
Date: Thu, 06 Oct 2022 19:43:14 +0000	[thread overview]
Message-ID: <7cee38788a7a3c2c09a238e01c5bd825445f999d.1665085395.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1375.git.1665085395.gitgitgadget@gmail.com>

From: Jeff Hostetler <jeffhost@microsoft.com>

Add extra set of braces around zero initialization of two array/structure
variables to resolve compiler errors/warnings from clang 11.0.0 on MacOS.
This is not needed on clang 14.0.

$ uname -a
Darwin jeffhost-mbp.local 19.6.0 Darwin Kernel Version 19.6.0: \
       Mon Apr 18 21:50:40 PDT 2022; \
       root:xnu-6153.141.62~1/RELEASE_X86_64 x86_64
$ clang -v
Apple clang version 11.0.0 (clang-1100.0.33.17)
Target: x86_64-apple-darwin19.6.0
[...]

$ make builtin/merge-file.o
    CC builtin/merge-file.o
builtin/merge-file.c:29:23: error: suggest braces around initialization \
			    of subobject [-Werror,-Wmissing-braces]
        mmfile_t mmfs[3] = { 0 };
                             ^
                             {}
builtin/merge-file.c:31:20: error: suggest braces around initialization \
			    of subobject [-Werror,-Wmissing-braces]
        xmparam_t xmp = { 0 };
                          ^
                          {}
2 errors generated.
make: *** [builtin/merge-file.o] Error 1

Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
---
 builtin/merge-file.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/builtin/merge-file.c b/builtin/merge-file.c
index c923bbf2abb..607c3d3f9e1 100644
--- a/builtin/merge-file.c
+++ b/builtin/merge-file.c
@@ -26,9 +26,9 @@ static int label_cb(const struct option *opt, const char *arg, int unset)
 int cmd_merge_file(int argc, const char **argv, const char *prefix)
 {
 	const char *names[3] = { 0 };
-	mmfile_t mmfs[3] = { 0 };
+	mmfile_t mmfs[3] = { { 0 } };
 	mmbuffer_t result = { 0 };
-	xmparam_t xmp = { 0 };
+	xmparam_t xmp = { { 0 } };
 	int ret = 0, i = 0, to_stdout = 0;
 	int quiet = 0;
 	struct option options[] = {
-- 
gitgitgadget


  reply	other threads:[~2022-10-06 19:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 19:43 [PATCH 0/2] Fix syntax errors under clang 11.0.0 on MacOS Jeff Hostetler via GitGitGadget
2022-10-06 19:43 ` Jeff Hostetler via GitGitGadget [this message]
2022-10-06 21:09   ` [PATCH 1/2] builtin/merge-file: fix compiler error on MacOS with clang 11.0.0 René Scharfe
2022-10-06 22:30     ` Eric Sunshine
2022-10-06 22:51       ` Junio C Hamano
2022-10-06 19:43 ` [PATCH 2/2] builtin/unpack-objects.c: " Jeff Hostetler via GitGitGadget
2022-10-06 20:38 ` [PATCH 0/2] Fix syntax errors under clang 11.0.0 on MacOS Junio C Hamano
2022-10-06 20:58   ` Eric Sunshine
2022-10-07 11:02 ` Ævar Arnfjörð Bjarmason
2022-10-07 15:19 ` Jeff Hostetler
2022-10-07 17:49   ` Junio C Hamano
2022-10-07 20:28     ` René Scharfe
2022-10-07 20:56       ` Jeff Hostetler
2022-10-07 21:33         ` Junio C Hamano
2022-10-08  3:46           ` Eric Sunshine
2022-10-08  6:52             ` René Scharfe
2022-10-09  5:19               ` Junio C Hamano
2022-10-07 21:30       ` Junio C Hamano
2022-10-10 15:39 ` [PATCH v2] config.mak.dev: disable suggest braces error on old clang versions Jeff Hostetler via GitGitGadget
2022-10-10 18:13   ` Junio C Hamano
2022-10-11  0:15     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7cee38788a7a3c2c09a238e01c5bd825445f999d.1665085395.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jeffhost@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).