git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: "Jiang Xin" <worldhello.net@gmail.com>,
	"Git List" <git@vger.kernel.org>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Fabian Stelzer" <fs@gigacodes.de>,
	"ZheNing Hu" <adlternative@gmail.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Alexander Shopov" <ash@kambanaria.org>,
	"Jordi Mas" <jmas@softcatala.org>,
	"Matthias Rüster" <matthias.ruester@gmail.com>,
	"Jimmy Angelakos" <vyruss@hellug.gr>,
	"Christopher Díaz" <christopher.diaz.riv@gmail.com>,
	"Jean-Noël Avila" <jn.avila@free.fr>,
	"Alessandro Menti" <alessandro.menti@alessandromenti.it>,
	"Gwan-gyeong Mun" <elongbug@gmail.com>, Arusekk <arek_koz@o2.pl>,
	"Daniel Santos" <daniel@brilhante.top>,
	"Dimitriy Ryazantcev" <DJm00n@mail.ru>,
	"Peter Krefting" <peter@softwolves.pp.se>,
	"Emir SARI" <bitigchi@me.com>,
	"Trần Ngọc Quân" <vnwildman@gmail.com>,
	"Fangyi Zhou" <me@fangyi.io>, "Yi-Jyun Pan" <pan93412@gmail.com>
Subject: Re: [PATCH v2] i18n: fix typos found during l10n for git 2.34.0
Date: Tue, 2 Nov 2021 17:17:22 +0700	[thread overview]
Message-ID: <7d9a893e-5dad-bd21-4ef7-6d47303abdc1@gmail.com> (raw)
In-Reply-To: <20211101021417.9549-1-worldhello.net@gmail.com>

> diff --git a/builtin/index-pack.c b/builtin/index-pack.c
> index 15ae406e6b..c23d01de7d 100644
> --- a/builtin/index-pack.c
> +++ b/builtin/index-pack.c
> @@ -1486,7 +1486,7 @@ static void rename_tmp_packfile(const char **final_name,
>   		if (!*final_name)
>   			*final_name = odb_pack_name(name, hash, ext);
>   		if (finalize_object_file(curr_name, *final_name))
> -			die(_("unable to rename temporary '*.%s' file to '%s"),
> +			die(_("unable to rename temporary '*.%s' file to '%s'"),
>   			    ext, *final_name);
>   	} else if (make_read_only_if_same) {
>   		chmod(*final_name, 0444);
> diff --git a/gpg-interface.c b/gpg-interface.c
> index 800d8caa67..68d2f29be7 100644
> --- a/gpg-interface.c
> +++ b/gpg-interface.c
> @@ -775,7 +775,7 @@ static const char *get_default_ssh_signing_key(void)
>   		if (keys[0] && starts_with(keys[0]->buf, "ssh-")) {
>   			default_key = strbuf_detach(keys[0], NULL);
>   		} else {
> -			warning(_("gpg.ssh.defaultKeycommand succeeded but returned no keys: %s %s"),
> +			warning(_("gpg.ssh.defaultKeyCommand succeeded but returned no keys: %s %s"),
>   				key_stderr.buf, key_stdout.buf);
>   		}
>   

Looks OK.

> diff --git a/ref-filter.c b/ref-filter.c
> index 282cdad103..08a3f839c9 100644
> --- a/ref-filter.c
> +++ b/ref-filter.c
> @@ -1037,7 +1037,7 @@ int verify_ref_format(struct ref_format *format)
>   		     format->quote_style == QUOTE_TCL) &&
>   		     used_atom[at].atom_type == ATOM_RAW &&
>   		     used_atom[at].u.raw_data.option == RAW_BARE)
> -			die(_("--format=%.*s cannot be used with"
> +			die(_("--format=%.*s cannot be used with "
>   			      "--python, --shell, --tcl"), (int)(ep - sp - 2), sp + 2);
>   		cp = ep + 1;
>   
> 

Why not using \n?

-- 
An old man doll... just what I always wanted! - Clara

  parent reply	other threads:[~2021-11-02 10:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-30  2:09 [L10N] Kickoff for Git 2.34.0 round #1 Jiang Xin
2021-10-31  5:21 ` [PATCH] i18n: fix typos found during l10n for git 2.34.0 Jiang Xin
2021-11-01  2:14   ` [PATCH v2] " Jiang Xin
2021-11-01  5:51     ` Junio C Hamano
2021-11-02 10:17     ` Bagas Sanjaya [this message]
2021-11-03 16:26       ` Junio C Hamano
2021-11-04  1:27         ` Jiang Xin
2021-11-02 11:28   ` [PATCH] " ZheNing Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d9a893e-5dad-bd21-4ef7-6d47303abdc1@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=DJm00n@mail.ru \
    --cc=adlternative@gmail.com \
    --cc=alessandro.menti@alessandromenti.it \
    --cc=arek_koz@o2.pl \
    --cc=ash@kambanaria.org \
    --cc=avarab@gmail.com \
    --cc=bitigchi@me.com \
    --cc=christopher.diaz.riv@gmail.com \
    --cc=daniel@brilhante.top \
    --cc=elongbug@gmail.com \
    --cc=fs@gigacodes.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jmas@softcatala.org \
    --cc=jn.avila@free.fr \
    --cc=matthias.ruester@gmail.com \
    --cc=me@fangyi.io \
    --cc=pan93412@gmail.com \
    --cc=peter@softwolves.pp.se \
    --cc=vnwildman@gmail.com \
    --cc=vyruss@hellug.gr \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).