From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Vincent Mailhol" <mailhol@kernel.org>, git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Philippe Blain" <levraiphilippeblain@gmail.com>,
"Patrick Steinhardt" <ps@pks.im>,
"D. Ben Knoble" <ben.knoble@gmail.com>
Subject: Re: [PATCH v3 0/4] completion: add support for 'git history'
Date: Fri, 14 Aug 2026 09:50:22 +0200 [thread overview]
Message-ID: <7dd74cba-2149-4d31-9d45-2c355137bf0d@app.fastmail.com> (raw)
In-Reply-To: <3d0e8944-c17b-4665-88e0-2f955d52e8e9@kernel.org>
On Fri, Aug 14, 2026, at 08:25, Vincent Mailhol wrote:
>[snip]
> As you guessed, b4 removed the line starting with #3. I didn't see this
> coming. From now on, I will stop using # in the description.
You have a new enough Git (2.54.0) that you can use `core.commentString`
if you like. And with that you can set it to a string that you would
never type yourself.
That’s more of an assurance than `core.commentChar` which was limited to
one ASCII character.
>
> Should I send a v4 with the fixed cover letter, or is it OK as-is?
No, no new version necessary. It wasn’t my intention to make a reroll
out of a molehill.
prev parent reply other threads:[~2026-08-14 7:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 19:56 [PATCH] completion: add 'git history' subcommands Vincent Mailhol
2026-08-05 6:19 ` Patrick Steinhardt
2026-08-05 11:56 ` D. Ben Knoble
2026-08-05 16:15 ` Junio C Hamano
2026-08-05 21:20 ` Vincent Mailhol
2026-08-06 5:18 ` Patrick Steinhardt
2026-08-13 19:05 ` [PATCH v3 0/4] completion: add support for 'git history' Vincent Mailhol
2026-08-13 19:05 ` [PATCH v3 1/4] completion: add 'git history' subcommands Vincent Mailhol
2026-08-13 19:05 ` [PATCH v3 2/4] completion: complete 'git history --empty' values Vincent Mailhol
2026-08-13 19:05 ` [PATCH v3 3/4] completion: complete 'git history --update-refs' values Vincent Mailhol
2026-08-13 19:05 ` [PATCH v3 4/4] completion: complete 'git history split' pathspecs Vincent Mailhol
2026-08-13 20:30 ` [PATCH v3 0/4] completion: add support for 'git history' Kristoffer Haugsbakk
2026-08-14 6:25 ` Vincent Mailhol
2026-08-14 7:50 ` Kristoffer Haugsbakk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dd74cba-2149-4d31-9d45-2c355137bf0d@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=levraiphilippeblain@gmail.com \
--cc=mailhol@kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox