Git development
 help / color / mirror / Atom feed
From: Phillip Wood <phillip.wood123@gmail.com>
To: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>,
	phillip.wood@dunelm.org.uk
Cc: git@vger.kernel.org, jltobler@gmail.com,
	lucasseikioshiro@gmail.com, gitster@pobox.com
Subject: Re: [GSoC Patch v9 0/5] repo: add path keys to repo info
Date: Sun, 15 Nov 2026 16:17:11 +0000	[thread overview]
Message-ID: <7e5188f8-ab49-495a-bddd-7ba8921c11e0@gmail.com> (raw)
In-Reply-To: <CA+rGoLfJyuT7+W_eVPap_KSqy4EFG4Avp2=rL=hsLu0uXxem4w@mail.gmail.com>

On 15/11/2026 11:03, K Jayatheerth wrote:
> On Sun, Nov 15, 2026 at 4:03 PM Phillip Wood <phillip.wood123@gmail.com> wrote:
>> On 14/11/2026 16:37, K Jayatheerth wrote:
>>>
>>> Changes since v8:
>>>     - Dropped `path.hooks` and `path.cdup`.
>>>     - Renamed `path.toplevel.*` to `path.workingtree.*` to align with the
>>>       standard "working tree" glossary term while avoiding hyphens in
>>>       configuration variable names.
>>>     - Renamed `path.superproject-root.*` to `path.superprojectworkingtree.*`
>>>       to provide a descriptive name for scripts while avoiding hyphens.
>>>     - Renamed `path.git-prefix` to `path.prefix` to shorten it and avoid
>>>       hyphens.
>>
>> The range-diff looks good. It is a shame we're still creating a new
>> repository for each test when the majority of the tests could happily
>> run in the repository that the test framework creates for us. No one
>> else seems to mind that, even though it makes our test suite slower than
>> it needs to be, so I'd be happy if this is merged as-is.
>>
> Whoops, apologies for missing that, I made a checklist for this
> reroll, read your
> note about the tests, and completely forgot to add it to the list :)

Not to worry, it is easily done

> Also there are some newly arised questions about this in my mind:
> 
> - I am currently writing a follow-up series to consolidate the overlapping logic
> between `repo` and `rev-parse`, and I plan to combine and clean up the tests
> there as well.
> - Three `path.*` keys were already merged in an earlier round, so updating those
> tests would require a separate commit anyway.
> 
> That said, I'm open to feedback and happy to switch the tests in this
> series to run in
> a single repository if you think it's worth doing now.
If you're planning some test cleanups anyway then I'm happy for the 
tests here to be cleaned up by a future series. I'd do whatever you 
think is easiest for you.

Thanks

Phillip

  reply	other threads:[~2026-11-15 16:17 UTC|newest]

Thread overview: 135+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16  1:21 [GSoC Patch 0/7] repo: add more path keys to git repo info K Jayatheerth
2026-07-16  1:21 ` [GSoC Patch 1/7] repo: add path.toplevel with absolute and relative suffix formatting K Jayatheerth
2026-08-15 23:06   ` Lucas Seiki Oshiro
2026-08-18 16:09     ` K Jayatheerth
2026-07-16  1:21 ` [GSoC Patch 2/7] repo: add path.superproject-working-tree with absolute and relative suffixes K Jayatheerth
2026-07-16  1:21 ` [GSoC Patch 3/7] repo: add path.objects with absolute and relative suffix formatting K Jayatheerth
2026-07-16  1:21 ` [GSoC Patch 4/7] repo: add path.hooks " K Jayatheerth
2026-07-16  1:21 ` [GSoC Patch 5/7] repo: add path.index " K Jayatheerth
2026-07-16  1:21 ` [GSoC Patch 6/7] repo: add path.grafts " K Jayatheerth
2026-07-16  1:21 ` [GSoC Patch 7/7] repo: add path.git-prefix path key validation K Jayatheerth
2026-07-16  3:23   ` Junio C Hamano
2026-07-16 15:36     ` K Jayatheerth
2026-07-17 13:30 ` [GSoC Patch v2 0/7] repo: add more path keys to git repo info K Jayatheerth
2026-07-17 13:30   ` [GSoC Patch v2 1/7] repo: add path.toplevel with absolute and relative suffix formatting K Jayatheerth
2026-07-17 13:30   ` [GSoC Patch v2 2/7] repo: add path.superproject-working-tree with absolute and relative suffixes K Jayatheerth
2026-07-17 13:30   ` [GSoC Patch v2 3/7] repo: add path.objects with absolute and relative suffix formatting K Jayatheerth
2026-07-17 13:30   ` [GSoC Patch v2 4/7] repo: add path.hooks " K Jayatheerth
2026-07-17 13:30   ` [GSoC Patch v2 5/7] repo: add path.index " K Jayatheerth
2026-07-20  0:35     ` Lucas Seiki Oshiro
2026-07-24 17:49       ` K Jayatheerth
2026-07-24 19:21         ` Junio C Hamano
2026-07-17 13:30   ` [GSoC Patch v2 6/7] repo: add path.grafts " K Jayatheerth
2026-07-20  0:20     ` Lucas Seiki Oshiro
2026-07-20  4:01       ` Junio C Hamano
2026-07-21  2:19         ` K Jayatheerth
2026-07-17 13:30   ` [GSoC Patch v2 7/7] repo: add path.git-prefix path key K Jayatheerth
2026-07-26 10:43 ` [GSoC Patch v3 0/7] repo: add more path keys to git repo info K Jayatheerth
2026-07-26 10:43   ` [PATCH v3 1/7] repo: add path.toplevel with absolute and relative suffix formatting K Jayatheerth
2026-07-27  8:45     ` Junio C Hamano
2026-07-28  1:21       ` K Jayatheerth
2026-07-28 16:36     ` Justin Tobler
2026-07-29 16:36       ` K Jayatheerth
2026-07-26 10:43   ` [PATCH v3 2/7] repo: add path.superproject-working-tree with absolute and relative suffixes K Jayatheerth
2026-07-28 16:43     ` Justin Tobler
2026-07-26 10:43   ` [PATCH v3 3/7] repo: add path.objects with absolute and relative suffix formatting K Jayatheerth
2026-07-28 17:12     ` Justin Tobler
2026-07-26 10:43   ` [PATCH v3 4/7] repo: add path.hooks " K Jayatheerth
2026-07-28 19:00     ` Justin Tobler
2026-07-26 10:43   ` [PATCH v3 5/7] repo: add path.index " K Jayatheerth
2026-07-26 10:43   ` [PATCH v3 6/7] repo: add path.grafts " K Jayatheerth
2026-07-26 10:43   ` [PATCH v3 7/7] repo: add path.git-prefix path key K Jayatheerth
2026-07-26 16:29   ` [GSoC Patch v3 0/7] repo: add more path keys to git repo info Junio C Hamano
2026-07-26 17:00     ` K Jayatheerth
2026-07-27  0:57     ` Lucas Seiki Oshiro
2026-07-27  5:55       ` Junio C Hamano
2026-08-06 10:15 ` [GSoC PATCH v4 " K Jayatheerth
2026-08-06 10:15   ` [GSoC PATCH v4 1/7] repo: add path.toplevel with absolute and relative suffix formatting K Jayatheerth
2026-08-06 10:15   ` [GSoC PATCH v4 2/7] repo: add path.superproject-root with absolute and relative suffixes K Jayatheerth
2026-08-06 10:15   ` [GSoC PATCH v4 3/7] repo: add path.hooks " K Jayatheerth
2026-08-06 10:15   ` [GSoC PATCH v4 4/7] repo: add path.index " K Jayatheerth
2026-08-06 10:15   ` [GSoC PATCH v4 5/7] repo: add path.grafts " K Jayatheerth
2026-08-06 10:15   ` [GSoC PATCH v4 6/7] repo: add path.git-prefix K Jayatheerth
2026-08-16  0:53     ` Lucas Seiki Oshiro
2026-08-18 16:33       ` K Jayatheerth
2026-08-18 17:09         ` Junio C Hamano
2026-08-21 14:08           ` K Jayatheerth
2026-08-06 10:15   ` [GSoC PATCH v4 7/7] repo: remove unused setup.h include K Jayatheerth
2026-08-25 17:58 ` [GSoC Patch v5 0/7] add more path keys to git repo info K Jayatheerth
2026-08-25 17:58   ` [GSoC Patch v5 1/7] repo: add path.toplevel with absolute and relative suffix formatting K Jayatheerth
2026-08-25 17:58   ` [GSoC Patch v5 2/7] repo: add path.superproject-root with absolute and relative suffixes K Jayatheerth
2026-09-04 22:09     ` Junio C Hamano
2026-09-05 10:01       ` K Jayatheerth
2026-08-25 17:58   ` [GSoC Patch v5 3/7] repo: add path.hooks " K Jayatheerth
2026-08-25 17:58   ` [GSoC Patch v5 4/7] repo: add path.index " K Jayatheerth
2026-08-25 17:58   ` [GSoC Patch v5 5/7] repo: add path.grafts " K Jayatheerth
2026-08-25 17:58   ` [GSoC Patch v5 6/7] repo: add path.git-prefix K Jayatheerth
2026-08-25 17:58   ` [GSoC Patch v5 7/7] repo: add path.cdup K Jayatheerth
2026-08-25 19:31     ` Junio C Hamano
2026-09-04 14:37       ` K Jayatheerth
2026-08-26  7:23   ` [GSoC Patch v5 0/7] add more path keys to git repo info SZEDER Gábor
2026-08-26 14:18     ` Junio C Hamano
2026-09-11 14:45 ` [GSoC Patch v6 " K Jayatheerth
2026-09-11 14:45   ` [GSoC Patch v6 1/7] repo: add path.toplevel with absolute and relative suffix formatting K Jayatheerth
2026-09-11 14:45   ` [GSoC Patch v6 2/7] repo: add path.superproject-root with absolute and relative suffixes K Jayatheerth
2026-09-11 22:08     ` Junio C Hamano
2026-09-23 17:40       ` K Jayatheerth
2026-09-11 14:45   ` [GSoC Patch v6 3/7] repo: add path.hooks " K Jayatheerth
2026-09-11 14:45   ` [GSoC Patch v6 4/7] repo: add path.index " K Jayatheerth
2026-09-11 16:55     ` Junio C Hamano
2026-09-23 17:25       ` K Jayatheerth
2026-09-11 14:45   ` [GSoC Patch v6 5/7] repo: add path.grafts " K Jayatheerth
2026-09-11 14:45   ` [GSoC Patch v6 6/7] repo: add path.git-prefix K Jayatheerth
2026-09-11 14:45   ` [GSoC Patch v6 7/7] repo: add path.cdup K Jayatheerth
2026-09-11 17:37     ` Junio C Hamano
2026-09-23 17:37       ` K Jayatheerth
2026-09-27 11:44 ` [GSoC Patch v7 0/8] add more path keys to git repo info K Jayatheerth
2026-09-27 11:44   ` [GSoC Patch v7 1/8] repo: add path.toplevel with absolute and relative suffix formatting K Jayatheerth
2026-09-27 11:44   ` [GSoC Patch v7 2/8] submodule: use repository to find superproject K Jayatheerth
2026-11-02 21:36     ` Justin Tobler
2026-11-03  2:08       ` K Jayatheerth
2026-09-27 11:44   ` [GSoC Patch v7 3/8] repo: add path.superproject-root with absolute and relative suffixes K Jayatheerth
2026-11-02 21:43     ` Justin Tobler
2026-11-03  2:10       ` K Jayatheerth
2026-09-27 11:44   ` [GSoC Patch v7 4/8] repo: add path.hooks " K Jayatheerth
2026-11-02 22:32     ` Justin Tobler
2026-11-03  2:31       ` K Jayatheerth
2026-11-03 16:16         ` Justin Tobler
2026-11-03 18:27           ` K Jayatheerth
2026-09-27 11:44   ` [GSoC Patch v7 5/8] repo: add path.index " K Jayatheerth
2026-09-27 11:44   ` [GSoC Patch v7 6/8] repo: add path.grafts " K Jayatheerth
2026-11-02 22:47     ` Justin Tobler
2026-11-03  2:50       ` K Jayatheerth
2026-09-27 11:44   ` [GSoC Patch v7 7/8] repo: add path.git-prefix K Jayatheerth
2026-09-27 11:44   ` [GSoC Patch v7 8/8] repo: add path.cdup K Jayatheerth
2026-11-02 23:20     ` Justin Tobler
2026-11-03  2:54       ` K Jayatheerth
2026-11-01 23:30   ` [GSoC Patch v7 0/8] add more path keys to git repo info Junio C Hamano
2026-11-01 23:51     ` Justin Tobler
2026-11-02  9:31   ` Junio C Hamano
2026-11-07 16:00 ` [GSoC Patch v8 0/7] repo: add path keys to " K Jayatheerth
2026-11-07 16:00   ` [GSoC Patch v8 1/7] repo: add path.toplevel with absolute and relative suffix formatting K Jayatheerth
2026-11-07 16:00   ` [GSoC Patch v8 2/7] submodule: use repository to find superproject K Jayatheerth
2026-11-07 16:00   ` [GSoC Patch v8 3/7] repo: add path.superproject-root with absolute and relative suffixes K Jayatheerth
2026-11-07 16:00   ` [GSoC Patch v8 4/7] repo: add path.hooks " K Jayatheerth
2026-11-07 16:00   ` [GSoC Patch v8 5/7] repo: add path.index " K Jayatheerth
2026-11-07 16:00   ` [GSoC Patch v8 6/7] repo: add path.git-prefix K Jayatheerth
2026-11-07 16:01   ` [GSoC Patch v8 7/7] repo: add path.cdup K Jayatheerth
2026-11-07 19:57   ` [GSoC Patch v8 0/7] repo: add path keys to repo info Phillip Wood
2026-11-09 16:52     ` K Jayatheerth
2026-11-09 19:53       ` Junio C Hamano
2026-11-10 14:43         ` Phillip Wood
2026-11-11  9:05         ` K Jayatheerth
2026-11-10 14:40       ` Phillip Wood
2026-11-11  9:03         ` K Jayatheerth
2026-11-11 14:03           ` Phillip Wood
2026-11-14 16:37 ` [GSoC Patch v9 0/5] " K Jayatheerth
2026-11-14 16:37   ` [GSoC Patch v9 1/5] repo: add path.workingtree with absolute and relative suffix formatting K Jayatheerth
2026-11-14 16:37   ` [GSoC Patch v9 2/5] submodule: use repository to find superproject K Jayatheerth
2026-11-14 16:37   ` [GSoC Patch v9 3/5] repo: add path.superprojectworkingtree with absolute and relative suffixes K Jayatheerth
2026-11-14 16:37   ` [GSoC Patch v9 4/5] repo: add path.index " K Jayatheerth
2026-11-14 16:37   ` [GSoC Patch v9 5/5] repo: add path.prefix K Jayatheerth
2026-11-15 10:33   ` [GSoC Patch v9 0/5] repo: add path keys to repo info Phillip Wood
2026-11-15 11:03     ` K Jayatheerth
2026-11-15 16:17       ` Phillip Wood [this message]
2026-11-16 13:00         ` K Jayatheerth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e5188f8-ab49-495a-bddd-7ba8921c11e0@gmail.com \
    --to=phillip.wood123@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jayatheerthkulkarni2005@gmail.com \
    --cc=jltobler@gmail.com \
    --cc=lucasseikioshiro@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox