From: "Rubén Justo" <rjusto@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Git List <git@vger.kernel.org>, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH] t0613: mark as leak-free
Date: Mon, 1 Jul 2024 21:35:56 +0200 [thread overview]
Message-ID: <7ef69875-b18f-4ccb-be83-e994315636bd@gmail.com> (raw)
In-Reply-To: <20240701035759.GF610406@coredump.intra.peff.net>
On Sun, Jun 30, 2024 at 11:57:59PM -0400, Jeff King wrote:
> On Sun, Jun 30, 2024 at 08:46:38AM +0200, Rubén Justo wrote:
>
> > We can mark t0613 as leak-free:
> > [...]
> > I'm not sure why this simple change has fallen through the cracks.
> > Therefore, it's possible that I'm missing something.
> >
> > I'd appreciate if someone could double-check.
>
> I'd noticed it, too, while doing recent leak fixes. But since Patrick
> has been working on leaks and is the go-to person for reftables, I
> assumed he had already seen it and there was something clever going on. ;)
>
> I also get a passing result from t0612 (and I do have JGit available, so
> it actually runs the tests).
I have no idea how JGit works, and I didn't have it installed either.
But after a quick test, I can confirm that t0612 can also be marked as
leak-free.
I'll respond to this message shortly with a patch to fix that.
>
> I also get funny results from t4255, but I think we can ignore them.
> It's known breakages vanishing, which I guess is just some sub-program
> returning failure due to a leak and changing the test results.
>
> So anyway, this patch looks good to me, but probably we could squash
> t0612 into it, as well.
>
> -Peff
Thank you!
next prev parent reply other threads:[~2024-07-01 19:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-30 6:46 [PATCH] t0613: mark as leak-free Rubén Justo
2024-07-01 3:57 ` Jeff King
2024-07-01 19:35 ` Rubén Justo [this message]
2024-07-01 19:38 ` t0612: " Rubén Justo
2024-07-01 19:40 ` Eric Sunshine
2024-07-01 19:44 ` [PATCH] " Rubén Justo
2024-07-22 9:02 ` [PATCH] t0613: " Patrick Steinhardt
2024-07-23 21:03 ` Jeff King
2024-07-23 23:07 ` Re* " Rubén Justo
2024-07-24 5:16 ` Patrick Steinhardt
2024-07-24 6:45 ` Rubén Justo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ef69875-b18f-4ccb-be83-e994315636bd@gmail.com \
--to=rjusto@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).