git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: git@vger.kernel.org
Subject: Problems with 82e79c63642c, NOT_CONSTANT with sigfillset()
Date: Sun, 4 May 2025 21:04:57 +0200	[thread overview]
Message-ID: <7efc9c9c-8187-4e10-bf9d-1cbb6aeac124@web.de> (raw)

There is a problem with the somewhat new
commit 82e79c63642c introducing NOT_CONSTANT with sigfillset():

Compiling on older (?) MacOs machine leads to this:
     Undefined symbols for architecture x86_64:
       "_false_but_the_compiler_does_not_know_it_", referenced from:
           _start_command in libgit.a(run-command.o)

What is the best thing to avoid this ?

The introduced "false_but_the_compiler_does_not_know_it" triggers here
because there is a proper prototype in signal.h and then a
#define sigfillset() ...
further down in the file, which can never fail.

a) Define a sigfillset_or_die_if_needed macro,
   which does what we have today, and is simply defined
   as sigfillset() without any error checking for MacOs(some version)
b) Revert the commit (and fix the conflicts)
c) Anything better ?

I have a raw patch for b), not fully cooked, as the commit message
is the hardest part. Before sending that out:
Are the thoughts about a better solution ?





             reply	other threads:[~2025-05-04 19:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-04 19:04 Torsten Bögershausen [this message]
2025-05-05 20:47 ` Problems with 82e79c63642c, NOT_CONSTANT with sigfillset() Junio C Hamano
2025-05-06  6:14   ` Koji Nakamaru
2025-05-06 12:06 ` [PATCH/RFC v1 1/1] intialize false_but_the_compiler_does_not_know_it_ tboegi
2025-05-06 17:16   ` Junio C Hamano
2025-05-07  1:22     ` Koji Nakamaru
2025-05-07 16:27       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7efc9c9c-8187-4e10-bf9d-1cbb6aeac124@web.de \
    --to=tboegi@web.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).