* [PATCH] Makefile: Use libc strlcpy on OSX
@ 2009-01-24 15:41 Benjamin Kramer
2009-01-24 18:39 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Kramer @ 2009-01-24 15:41 UTC (permalink / raw)
To: git; +Cc: gitster
OSX supports strlcpy(3) since 10.2 so we don't need
to use our own.
Signed-off-by: Benjamin Kramer <benny.kra@gmail.com>
---
Makefile | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index b4d9cb4..4c9aab5 100644
--- a/Makefile
+++ b/Makefile
@@ -643,7 +643,6 @@ ifeq ($(uname_S),Darwin)
ifneq ($(shell expr "$(uname_R)" : '9\.'),2)
OLD_ICONV = UnfortunatelyYes
endif
- NO_STRLCPY = YesPlease
NO_MEMMEM = YesPlease
THREADED_DELTA_SEARCH = YesPlease
endif
--
1.6.1.285.g3454
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile: Use libc strlcpy on OSX
2009-01-24 15:41 [PATCH] Makefile: Use libc strlcpy on OSX Benjamin Kramer
@ 2009-01-24 18:39 ` Junio C Hamano
2009-01-24 18:51 ` Benjamin Kramer
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2009-01-24 18:39 UTC (permalink / raw)
To: Benjamin Kramer; +Cc: git
Benjamin Kramer <benny.kra@googlemail.com> writes:
> OSX supports strlcpy(3) since 10.2 so we don't need
> to use our own.
How does your patch to Makefile refrain from kicking in for people with
OSX older than 10.2, so that their builds are not broken?
>
> Signed-off-by: Benjamin Kramer <benny.kra@gmail.com>
> ---
> Makefile | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index b4d9cb4..4c9aab5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -643,7 +643,6 @@ ifeq ($(uname_S),Darwin)
> ifneq ($(shell expr "$(uname_R)" : '9\.'),2)
> OLD_ICONV = UnfortunatelyYes
> endif
> - NO_STRLCPY = YesPlease
> NO_MEMMEM = YesPlease
> THREADED_DELTA_SEARCH = YesPlease
> endif
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile: Use libc strlcpy on OSX
2009-01-24 18:39 ` Junio C Hamano
@ 2009-01-24 18:51 ` Benjamin Kramer
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Kramer @ 2009-01-24 18:51 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On Sat, Jan 24, 2009 at 19:39, Junio C Hamano <gitster@pobox.com> wrote:
> How does your patch to Makefile refrain from kicking in for people with
> OSX older than 10.2, so that their builds are not broken?
I'm not even sure anyone uses <= 10.1 nowadays. But of course you're right,
I'll write a better patch.
-- Benjamin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-24 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-24 15:41 [PATCH] Makefile: Use libc strlcpy on OSX Benjamin Kramer
2009-01-24 18:39 ` Junio C Hamano
2009-01-24 18:51 ` Benjamin Kramer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).