git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Geoffrey Irving" <irving@naml.us>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: cherry picking changesets instead of commits
Date: Wed, 28 May 2008 12:42:12 -0700	[thread overview]
Message-ID: <7f9d599f0805281242w5769a100s1153c2101992ff55@mail.gmail.com> (raw)
In-Reply-To: <7vod6qtgfs.fsf@gitster.siamese.dyndns.org>

On Wed, May 28, 2008 at 11:46 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Geoffrey Irving <geoffrey.irving@gmail.com> writes:
>
>> On May 28, 2008, at 11:19 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>
>>> "Geoffrey Irving" <irving@naml.us> writes:
>>>
>>>> Would it be straightforward
>>>> to add an option to "git cherry" to ignore differences in metadata?
>>>> The cherry documentation doesn't give its criteria for when commits
>>>> match, and I'm not familiar enough with the code yet to figure out
>>>> those criteria directly from cmd_cherry in builtin-log.c.
>>>
>>> cherry does not look at metadata at all.  It compares patch-ids.
>>
>> Can you define what a patch-id is?
>
> $ man git-patch-id

Thanks!  Here's a patch to avoid duplicating this particular ignorant question.

Geoffrey

commit a1bac5e1aa52f9a78733aa35a0a7e820df618301
Author: Geoffrey Irving <irving@naml.us>
Date:   Wed May 28 12:38:11 2008 -0700

    doc: mention git-patch-id in git-cherry documentation

diff --git a/Documentation/git-cherry.txt b/Documentation/git-cherry.txt
index b0468aa..9817fb5 100644
--- a/Documentation/git-cherry.txt
+++ b/Documentation/git-cherry.txt
@@ -41,6 +41,8 @@ has been applied <upstream> under a different commit
id.  For example,
 this will happen if you're feeding patches <upstream> via email rather
 than pushing or pulling commits directly.

+For details about how patches are compared, see git-patch-id.
+

 OPTIONS
 -------

  reply	other threads:[~2008-05-28 19:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-28 18:06 cherry picking changesets instead of commits Geoffrey Irving
2008-05-28 18:19 ` Junio C Hamano
2008-05-28 18:28   ` Geoffrey Irving
2008-05-28 18:46     ` Junio C Hamano
2008-05-28 19:42       ` Geoffrey Irving [this message]
2008-05-28 20:46         ` Junio C Hamano
2008-05-28 21:14           ` Geoffrey Irving
2008-05-28 22:38             ` Jeff King
2008-05-28 22:48               ` Jeff King
2008-05-28 23:56                 ` Junio C Hamano
2008-05-29  0:12                   ` Jeff King
2008-05-29  0:04             ` [PATCH] Documentation: git-cherry uses git-patch-id Junio C Hamano
2008-05-29  0:07               ` Geoffrey Irving

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f9d599f0805281242w5769a100s1153c2101992ff55@mail.gmail.com \
    --to=irving@naml.us \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).