git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	git@vger.kernel.org, kraai@ftbfs.org
Subject: Re: [PATCH] tests: turn on test-lint-shell-syntax by default
Date: Sat, 26 Jan 2013 13:43:23 -0800	[thread overview]
Message-ID: <7v1ud71uys.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <51037E5F.8090506@web.de> ("Torsten Bögershausen"'s message of "Sat, 26 Jan 2013 07:57:35 +0100")

Torsten Bögershausen <tboegi@web.de> writes:

> Do we really need  "which" to detect if frotz is installed?

I think we all know the answer to that question is no, but why is
that a relevant question in the context of this discussion?  One of
us may be very confused.

I thought the topic of this discussion was that, already knowing
that "which" should never be used anywhere in our scripts, you are
trying to devise a mechanical way to catch newcomers' attempts to
use it in their changes, in order to prevent patches that add use of
"which" to be sent for review to waste our time.  I was illustrating
that the approach to override "which" in a shell function for test
scripts will not be a useful solution for that goal.

  reply	other threads:[~2013-01-26 21:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-12  5:50 [PATCH] tests: turn on test-lint-shell-syntax by default Torsten Bögershausen
2013-01-12  6:00 ` Junio C Hamano
2013-01-13 10:25   ` Torsten Bögershausen
2013-01-13 16:50     ` Matt Kraai
2013-01-13 17:32     ` Jonathan Nieder
2013-01-13 22:38       ` Junio C Hamano
2013-01-15 20:12         ` Torsten Bögershausen
2013-01-15 20:38           ` Junio C Hamano
2013-01-26  6:57             ` Torsten Bögershausen
2013-01-26 21:43               ` Junio C Hamano [this message]
2013-01-27  7:43                 ` Torsten Bögershausen
2013-01-27  9:31               ` Jonathan Nieder
2013-01-27 13:13                 ` Torsten Bögershausen
2013-01-27 17:34                   ` Junio C Hamano
2013-01-27 20:25                     ` Junio C Hamano
2013-02-05 20:36                     ` Torsten Bögershausen
2013-02-05 20:52                       ` Junio C Hamano
2013-02-05 21:56                         ` Junio C Hamano
2013-01-27 17:15                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1ud71uys.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=kraai@ftbfs.org \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).