git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Charles Bailey <charles@hashpling.org>
Cc: David Aguilar <davvid@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	Tim Henigan <tim.henigan@gmail.com>
Subject: Re: What should mergetool do with --no-prompt?
Date: Tue, 14 Aug 2012 10:23:58 -0700	[thread overview]
Message-ID: <7v1uj9bd5d.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120814170900.GA28978@hashpling.org> (Charles Bailey's message of "Tue, 14 Aug 2012 18:09:00 +0100")

Charles Bailey <charles@hashpling.org> writes:

> On Tue, Aug 14, 2012 at 08:06:56AM -0700, Junio C Hamano wrote:
>> 
>> Could it be that the calling user or script does not even have a
>> terminal but still can spawn the chosen mergetool backend and
>> interact with the user via its GUI?  Or it may have a terminal that
>> is hard for the user to interact with, and the prompt and "read ans"
>> may get stuck.
>
> It could be, although this certainly wasn't considered in the original
> design. I know that we removed explicit references to /dev/tty and
> replaced them with exec n>&m juggling which made things generally more
> robust and allowed some basic shell tests to work more reliably. I
> don't object to handling non-interactive mode better but it feels
> unsatisfactory to only be able to resolve some types of conflict and
> have to skip others.

Exactly.  The mention of "a matching GUI" below you quoted was a
suggestion to improve that "only resolve some but not others"
problem.  The usual mergetool backend, e.g. meld, may not be capable
of resolving symlink conflicts, but "git mergetool" could run a GUI
dialog that gives the user "ours/theirs/fail" choice (or better yet
"merge result value" textbox in addition) for such a path.  The same
for delete/modify conflicts.

>> In such an environment, the ideal behaviour for the "git mergetool"
>> frontend may be not to interact via the terminal at all and instead
>> run its interaction to choose the resolution using a matching GUI
>> interface.

  reply	other threads:[~2012-08-14 17:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-14  7:07 What should mergetool do with --no-prompt? David Aguilar
2012-08-14  7:18 ` Charles Bailey
2012-08-14 15:06   ` Junio C Hamano
2012-08-14 17:09     ` Charles Bailey
2012-08-14 17:23       ` Junio C Hamano [this message]
2012-08-14 19:15         ` David Aguilar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1uj9bd5d.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=charles@hashpling.org \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=tim.henigan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).