From: Junio C Hamano <gitster@pobox.com>
To: Michael G Schwern <schwern@pobox.com>
Cc: Eric Wong <normalperson@yhbt.net>,
Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org, robbat2@gentoo.org,
bwalton@artsci.utoronto.ca
Subject: Re: [PATCH 4/4] Move initialization of Git::SVN variables into Git::SVN.
Date: Fri, 27 Jul 2012 14:31:43 -0700 [thread overview]
Message-ID: <7v1ujw28n4.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <50130062.7090901@pobox.com> (Michael G. Schwern's message of "Fri, 27 Jul 2012 13:56:02 -0700")
Michael G Schwern <schwern@pobox.com> writes:
> On 2012.7.27 1:07 PM, Eric Wong wrote:
>> While Makefile.PL now finds .pm files on its own, it does not
>> detect new files after it generates perl/perl.mak.
>
> Are you saying this doesn't work?
>
> perl Makefile.PL
> make -f perl.mak
> touch Git/Foo.pm
> perl Makefile.PL
> make -f perl.mak
>
> or this?
>
> perl Makefile.PL
> make -f perl.mak
> touch Git/Foo.pm
> make -f perl.mak
Neither of the above. Nobody should be typing "perl Makefile.PL"
inside our source tree unless he is trying to debug our Makefiles
anyway.
What does not work is this sequence:
make
>perl/Git/Foo.pm
make
Makefile at the top-level, which builds perl/perl.mak by running
"perl Makefile.PL" in perl/ subdirectory, doesn't have dependencies
[*1*], so in the above sequence, the second invocation of "make"
fails to rebuild perl/perl.mak, which causes Git/Foo.pm forgotten
from the build/installation step.
And that is what happened to Git/SVN.pm.
[Footnote]
*1* I also suspect perl/Makefile lacks this dependency even though
it has its own rule to build perl/perl.mak---don't they need to be
cleaned-up and merged???
next prev parent reply other threads:[~2012-07-27 21:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 23:22 Extract Git::SVN from git-svn, take 2 Michael G. Schwern
2012-07-26 23:22 ` [PATCH 1/4] Extract some utilities from git-svn to allow extracting Git::SVN Michael G. Schwern
2012-07-27 5:18 ` Junio C Hamano
2012-07-27 8:19 ` Michael G Schwern
2012-07-27 11:34 ` Eric Wong
2012-07-26 23:22 ` [PATCH 2/4] Prepare Git::SVN for extraction into its own file Michael G. Schwern
2012-07-27 5:18 ` Junio C Hamano
2012-07-27 5:23 ` Junio C Hamano
2012-07-27 8:16 ` Michael G Schwern
2012-07-27 11:53 ` Eric Wong
2012-07-26 23:22 ` [PATCH 4/4] Move initialization of Git::SVN variables into Git::SVN Michael G. Schwern
2012-07-27 5:18 ` Junio C Hamano
2012-07-27 5:38 ` Jonathan Nieder
2012-07-27 6:07 ` Junio C Hamano
2012-07-27 6:46 ` Junio C Hamano
2012-07-27 7:09 ` Junio C Hamano
2012-07-27 20:07 ` Eric Wong
2012-07-27 20:56 ` Michael G Schwern
2012-07-27 20:59 ` Eric Wong
2012-07-27 21:31 ` Junio C Hamano [this message]
2012-07-27 21:49 ` Junio C Hamano
2012-07-27 22:07 ` Eric Wong
2012-07-27 22:19 ` Eric Wong
2012-07-27 22:37 ` Junio C Hamano
2012-07-27 22:45 ` Eric Wong
2012-07-27 22:59 ` Junio C Hamano
2012-07-27 23:01 ` Eric Wong
2012-07-27 22:52 ` Junio C Hamano
2012-07-27 11:59 ` Eric Wong
2012-07-27 8:41 ` Michael G Schwern
-- strict thread matches above, loose matches on Subject: below --
2012-07-25 6:01 Move Git::SVN into its own .pm file Michael G. Schwern
2012-07-25 6:01 ` [PATCH 4/4] Move initialization of Git::SVN variables into Git::SVN Michael G. Schwern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1ujw28n4.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=normalperson@yhbt.net \
--cc=robbat2@gentoo.org \
--cc=schwern@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).