git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: git@vger.kernel.org, Fredrik Gustafsson <iveqy@iveqy.com>,
	Jens Lehmann <jens.lehmann@web.de>
Subject: Re: [PATCH v5 1/3] Teach revision walking machinery to walk multiple times sequencially
Date: Mon, 26 Mar 2012 14:28:49 -0700	[thread overview]
Message-ID: <7v1uofnjam.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120326193241.GA41087@book.hvoigt.net> (Heiko Voigt's message of "Mon, 26 Mar 2012 21:32:52 +0200")

Heiko Voigt <hvoigt@hvoigt.net> writes:

>> > +{
>> > +	clear_object_flags(SEEN | ADDED | SHOWN);
>> > +}
>> 
>> But is this really the right API?  After a particular program finishes
>> using the revision walker, wouldn't it want to clear both the set of these
>> standard flag bits used by the traversal machinery, as well as whatever
>> program specific bits it used to mark the objects with?
>
> Well if a program uses extra flags on objects it should clear the flags
> it set by using the clear_objects_flags() function itself. For example if
> the program wants to reuse those extra flags in a second revision walk
> it would not be possible if reset_revision_walk() would clear all flags.

OK.

>> These two hunk look like a *BUGFIX* to me (certainly it does not look like
>> this is an addition of any new feature).
>> 
>> What bug does this fix, and how is the current submodule code broken
>> without this patch?  Can you describe the problem in the log message, and
>> add a test to demonstrate the existing breakage?
>
> There is no breakage I know of. Its rather a cleanup which allows to
> call these functions multiple times. I did this to avoid surprises.

OK.

Thanks.

  reply	other threads:[~2012-03-26 21:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-13  9:25 [PATCH v5 0/3] push: submodule support Heiko Voigt
2012-02-13  9:27 ` [PATCH v5 1/3] Teach revision walking machinery to walk multiple times sequencially Heiko Voigt
2012-02-14  1:33   ` Junio C Hamano
2012-03-26 19:32     ` Heiko Voigt
2012-03-26 21:28       ` Junio C Hamano [this message]
2012-02-13  9:29 ` [PATCH v5 2/3] Refactor submodule push check to use string list instead of integer Heiko Voigt
2012-02-14  3:28   ` Junio C Hamano
2012-03-26 19:33     ` Heiko Voigt
2012-03-26 19:55       ` Heiko Voigt
2012-03-26 21:29         ` Junio C Hamano
2012-02-13  9:30 ` [PATCH v5 3/3] push: teach --recurse-submodules the on-demand option Heiko Voigt
2012-02-14  3:34   ` Junio C Hamano
2012-02-15 22:28     ` Jens Lehmann
2012-03-26 19:33       ` Heiko Voigt
2012-05-13 14:47       ` [RFC/PATCH] read from 2 filedescriptors simultaneously into one strbuf Heiko Voigt
2012-03-26 21:22   ` [PATCH v5 3/3] push: teach --recurse-submodules the on-demand option Zbigniew Jędrzejewski-Szmek
2012-03-28 15:30     ` Heiko Voigt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1uofnjam.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hvoigt@hvoigt.net \
    --cc=iveqy@iveqy.com \
    --cc=jens.lehmann@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).