* [PATCH (bugfix)] gitweb: Fix passing parameters to git_project_search_form
@ 2012-03-02 22:50 Jakub Narebski
2012-03-02 23:55 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Narebski @ 2012-03-02 22:50 UTC (permalink / raw)
To: git; +Cc: Jakub Narebski
The git_project_search_form() subroutine, introduced in a1e1b2d
(gitweb: improve usability of projects search form, 2012-01-31) didn't
get its arguments from caller correctly. Gitweb worked correctly
thanks to sticky-ness of form fields in CGI.pm... but it make UTF-8
fix for project search not working.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Brown paper bug (a1e1b2d is in master). I am extremly sorry about that.
gitweb/gitweb.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 7398be1..e2e6a73 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -5263,7 +5263,7 @@ sub git_patchset_body {
# . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .
sub git_project_search_form {
- my ($searchtext, $search_use_regexp);
+ my ($searchtext, $search_use_regexp) = @_;
my $limit = '';
if ($project_filter) {
--
1.7.9
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH (bugfix)] gitweb: Fix passing parameters to git_project_search_form
2012-03-02 22:50 [PATCH (bugfix)] gitweb: Fix passing parameters to git_project_search_form Jakub Narebski
@ 2012-03-02 23:55 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2012-03-02 23:55 UTC (permalink / raw)
To: Jakub Narebski; +Cc: git
Jakub Narebski <jnareb@gmail.com> writes:
> The git_project_search_form() subroutine, introduced in a1e1b2d
> (gitweb: improve usability of projects search form, 2012-01-31) didn't
> get its arguments from caller correctly. Gitweb worked correctly
> thanks to sticky-ness of form fields in CGI.pm... but it make UTF-8
> fix for project search not working.
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> Brown paper bug (a1e1b2d is in master). I am extremly sorry about that.
Heh, mistakes happen. Thanks for taking care of this.
>
> gitweb/gitweb.perl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 7398be1..e2e6a73 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -5263,7 +5263,7 @@ sub git_patchset_body {
> # . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .
>
> sub git_project_search_form {
> - my ($searchtext, $search_use_regexp);
> + my ($searchtext, $search_use_regexp) = @_;
>
> my $limit = '';
> if ($project_filter) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-02 23:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-02 22:50 [PATCH (bugfix)] gitweb: Fix passing parameters to git_project_search_form Jakub Narebski
2012-03-02 23:55 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).