From: Junio C Hamano <gitster@pobox.com>
To: Pang Yan Han <pangyanhan@gmail.com>
Cc: git@vger.kernel.org, Sitaram Chamarty <sitaramc@gmail.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
Jeff King <peff@peff.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH/RFCv3 2/2] receive-pack: don't pass non-existent refs to post-{receive,update} hooks in push deletions
Date: Fri, 30 Sep 2011 11:19:24 -0700 [thread overview]
Message-ID: <7v1uuxq4er.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20110930132903.GA1622@myhost> (Pang Yan Han's message of "Fri, 30 Sep 2011 21:29:03 +0800")
Pang Yan Han <pangyanhan@gmail.com> writes:
> Sorry for asking, but do I need to reroll this with the fixup in
> origin/ph/push-to-delete-nothing ? Is the commit message fine especially
> in light of the changes in the fixup?
If you think that the result of squashing the fix-up commit into your
patch looks OK, I do not think there is a need to reroll. The patch title
may need to be shortened, but other than that I do not see anything
glaringly wrong in the commit log message that I cannot amend out.
Thanks.
next prev parent reply other threads:[~2011-09-30 18:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 15:39 [PATCH/RFCv3 2/2] receive-pack: don't pass non-existent refs to post-{receive,update} hooks in push deletions Pang Yan Han
2011-09-28 22:37 ` Junio C Hamano
2011-09-28 23:08 ` Pang Yan Han
2011-09-28 23:28 ` Junio C Hamano
2011-09-30 13:29 ` Pang Yan Han
2011-09-30 18:19 ` Junio C Hamano [this message]
2011-09-28 23:09 ` Junio C Hamano
2011-09-28 23:11 ` Pang Yan Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1uuxq4er.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=pangyanhan@gmail.com \
--cc=peff@peff.net \
--cc=sitaramc@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).