From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Makefile: abort on shells that do not support
 ${parameter%word} expansion
Date: Tue, 06 Sep 2011 13:03:49 -0700
Message-ID: <7v1uvt8ml6.fsf@alter.siamese.dyndns.org>
References: <7vbouzxy7g.fsf@alter.siamese.dyndns.org>
 <rPnr5AVZRRnklxb_Yaj0gopXRTVCT-tq7iVG-1NoXjOrHWsyuLop-co4qtQjezJ98BaKc0R71r8fMcBOijq9oCOgfBF6ticVk17DwDQzV91bcC719fGSUPDsf40AuoRfgjURcxREkMk@cipher.nrlssc.navy.mil>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Naohiro Aota <naota@elisp.net>, git@vger.kernel.org,
	tarmigan+git@gmail.com, David Barr <davidbarr@google.com>,
	Brandon Casey <drafnel@gmail.com>
To: Brandon Casey <casey@nrlssc.navy.mil>
X-From: git-owner@vger.kernel.org Tue Sep 06 22:03:59 2011
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@lo.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1R11sE-0001TS-4R
	for gcvg-git-2@lo.gmane.org; Tue, 06 Sep 2011 22:03:58 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754911Ab1IFUDx (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Tue, 6 Sep 2011 16:03:53 -0400
Received: from b-pb-sasl-quonix.pobox.com ([208.72.237.35]:56662 "EHLO
	smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753293Ab1IFUDw (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 6 Sep 2011 16:03:52 -0400
Received: from smtp.pobox.com (unknown [127.0.0.1])
	by b-sasl-quonix.pobox.com (Postfix) with ESMTP id BB4B94D4E;
	Tue,  6 Sep 2011 16:03:51 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
	:subject:references:date:in-reply-to:message-id:mime-version
	:content-type; s=sasl; bh=6t00Jy3ICbFcBWY6bqXE5RXDt2M=; b=A69y5U
	TOx/ZhzbCmRK/joBAQlGE3nARxwoi6HIda1eQPY7aycU3utQc3g1iuqtNqjT+uqa
	6dJXa3UORLRzX7aMhO0j+DlXyQZPNO/0Wg20l09SeKZqUH54wQbFL7Xqx0kYe1sE
	zRgF84FQfJ7CCIcxwljzCAmFluvxr1ysNbb54=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc
	:subject:references:date:in-reply-to:message-id:mime-version
	:content-type; q=dns; s=sasl; b=p+fkpEtH5A1A6RJIv2CfYu4sAf8xhP7S
	+hMkdb4VbyRaMedR4kF/1c4W5iAFabBwDAIdGR2HufR7FbOBxva1JwFjoR4GT4XR
	TN7wWQ2zZ+eIlA0o6GJ8If5nmOSv0gSj3AaIUwiBvx13XxDL4Hi2GxFe9NVgfnnV
	1raKSQMyKuM=
Received: from b-pb-sasl-quonix.pobox.com (unknown [127.0.0.1])
	by b-sasl-quonix.pobox.com (Postfix) with ESMTP id B21E34D4D;
	Tue,  6 Sep 2011 16:03:51 -0400 (EDT)
Received: from pobox.com (unknown [76.102.170.102]) (using TLSv1 with cipher
 DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by
 b-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 3FA274D4A; Tue,  6 Sep 2011
 16:03:51 -0400 (EDT)
In-Reply-To: <rPnr5AVZRRnklxb_Yaj0gopXRTVCT-tq7iVG-1NoXjOrHWsyuLop-co4qtQjezJ98BaKc0R71r8fMcBOijq9oCOgfBF6ticVk17DwDQzV91bcC719fGSUPDsf40AuoRfgjURcxREkMk@cipher.nrlssc.navy.mil> (Brandon Casey's message of "Tue, 6 Sep 2011 14:09:43 -0500")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
X-Pobox-Relay-ID: 571F8904-D8C3-11E0-9D6D-9DB42E706CDE-77302942!b-pb-sasl-quonix.pobox.com
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/180828>

Brandon Casey <casey@nrlssc.navy.mil> writes:

> diff --git a/Makefile b/Makefile
> index 8d6d451..46d9c5d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1738,6 +1738,7 @@ endif
>  
>  please_set_SHELL_PATH_to_a_more_modern_shell:
>  	@$$(:)
> +	@foo=bar_suffix && test bar = "$${foo%_*}"
>  
>  shell_compatibility_test: please_set_SHELL_PATH_to_a_more_modern_shell

Perhaps

	@foo='bar?suffix' && test bar = "$${foo%\?*}"

instead?