git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Frédéric Heitzmann" <frederic.heitzmann@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git difftool does does not respect current working directory
Date: Sun, 15 May 2011 22:39:18 -0700	[thread overview]
Message-ID: <7v1uzznr09.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <loom.20110514T160931-46@post.gmane.org> ("Frédéric Heitzmann"'s message of "Sat, 14 May 2011 14:25:40 +0000 (UTC)")

Frédéric Heitzmann  <frederic.heitzmann@gmail.com> writes:

> Unfortunately, 'git difftool' does not keep the current working directory while
> launching gvimdiff.
>
> => Is it done on purpose ?
> If not, it is probably a good idea to fix this.

I will not comment on "on purpose?" part, as I do not use difftool myself.

But the right set of questions to ask is not the above, but these:

 - Is it on purpose that difftool runs its diff viewer from the top of the
   working tree?

 - Is there any existing user who depends on that current behaviour?  IOW,
   would anybody suffer if difftool suddenly starts to run the diff viewer
   from the subdirectory that the user started "git difftool" from?

If the answers to both of them are No, then it might be a good idea to
change the behaviour.

  reply	other threads:[~2011-05-16  5:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-14 14:25 git difftool does does not respect current working directory Frédéric Heitzmann
2011-05-16  5:39 ` Junio C Hamano [this message]
2011-05-20  3:59   ` David Aguilar
2011-05-20  4:10     ` David Aguilar
2011-05-20  4:31       ` Junio C Hamano
2011-05-20  4:48         ` David Aguilar
2011-05-21  9:35           ` Frédéric Heitzmann
2011-05-22  6:14             ` David Aguilar
2011-05-22  6:30               ` Junio C Hamano
2011-05-22  6:50                 ` David Aguilar
2011-05-22  9:57                 ` [PATCH 1/3] setup: Provide GIT_PREFIX to built-ins David Aguilar
2011-05-22  9:57                   ` [PATCH 2/3] git: Remove handling for GIT_PREFIX David Aguilar
2011-05-22  9:57                   ` [PATCH 3/3] git-mergetool--lib: Make vimdiff retain the current directory David Aguilar
2011-05-23  6:36                     ` Michael J Gruber
2011-05-23 19:59                     ` Junio C Hamano
2011-05-23 12:09                   ` [PATCH 1/3] setup: Provide GIT_PREFIX to built-ins Ævar Arnfjörð Bjarmason
2011-05-25  4:19                     ` David Aguilar
     [not found]                 ` <1306058055-93672-1-git-send-email-davvid@gmail.com>
     [not found]                   ` <4DDA0044.2060207@drmicha.warpmail.net>
2011-05-23  8:40                     ` David Aguilar
2011-05-23  9:58                       ` Michael J Gruber
2011-05-23 16:43                       ` Junio C Hamano
2011-05-24  7:23                         ` Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1uzznr09.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=frederic.heitzmann@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).