git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Dan McGee <dpmcgee@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fetch: show remote name instead of URL if available
Date: Tue, 26 Apr 2011 10:33:48 -0700	[thread overview]
Message-ID: <7v1v0ogbnn.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1303830807-21966-1-git-send-email-dpmcgee@gmail.com> (Dan McGee's message of "Tue, 26 Apr 2011 10:13:27 -0500")

Dan McGee <dpmcgee@gmail.com> writes:

>     $ git fetch -v
>     From git://git.kernel.org/pub/scm/git/git
>      = [up to date]      html       -> origin/html
>     ...

I see this full URL output as a nice reminder of what "origin" refers to,
especially when you said "git fetch -v origin".  This is especially useful
when you are fetching from different locations that house repositories of
the same project (e.g. among my multiple git.git working trees on my
notebook, some of them fetch from my private, primaty development machine
and others from public k.org).

Changing this output ...

> Versus the new output:
>
>     $ ./git fetch -v
>     From origin

... this way feels like a regression to me.

> Alternatively, we could do something like
>     From origin (git://git.kernel.org/pub/scm/git/git)

That is much less problematic.

But let's step back a bit.  What problem are you trying to solve?

Are you trying to give a reminder that you are interacting with 'origin'
when you said "git fetch -v" without saying where you are fetching from?
I think that is a good thing to aim for (the same reasoning behind the
comment of mine above).  If so, the ideal change from my gut feeling is to
add an extra " (origin)" at the end, like so:

	From git://git.kernel.org/pub/scm/git/git (origin)

when and only when the fetch is done without mentioning any remote
nickname; iow, "git fetch -v origin" or "git fetch -v git://.../git" won't
get the extra " (origin)" at the end.

  reply	other threads:[~2011-04-26 17:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26 15:13 [PATCH] fetch: show remote name instead of URL if available Dan McGee
2011-04-26 17:33 ` Junio C Hamano [this message]
2011-04-26 17:36   ` Drew Northup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1v0ogbnn.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=dpmcgee@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).