git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Michael Witten <mfwitten@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [RFC 0/5] Date Mode: Add --time-zone; deprecate --date=local
Date: Wed, 20 Apr 2011 20:57:25 -0700	[thread overview]
Message-ID: <7v1v0wz26y.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <BANLkTikbgfjq2J3K4_21zVQSTgnteZfMqg@mail.gmail.com> (Michael Witten's message of "Thu, 21 Apr 2011 02:14:20 +0000")

Michael Witten <mfwitten@gmail.com> writes:

>>> I took a cursory look, but I've spent so much time on this series already
>>> that I don't really care what it says...
>>
>> This is not a very good way to motivate somebody who is already tired at
>> the end of the day to reivew the RFC series, I would have to say.
>
> Then you can save us both time and just apply my series immediately :-P

That's not how things work around here.

The default is not to apply, unless the goal of the change is worthy and
the patch implements that change well.  It is submitter's job to convince
people that the change is worthy, justify that it is worth reviewers' time
to review the patch, and respond to questions and suggestions for
improvements.

By doing these responsibly, you win support for the particular patchset,
and win trust from others in you, which would affect further patches from
you.

It is not exactly a good way to win support to dump a patchset, to declare
that you are beyond the point of rethinking, to say a take-it-or-leave-it,
nor to defend your private style that goes against the project's coding
style (style is subjective and there is no right or wrong).

I know you know all of the above from your ":-P" (and your past patch
submissions), but I am writing these down so that people new to the list
do not get a wrong impression from this exchange.

  reply	other threads:[~2011-04-21  3:57 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-20  2:53 [RFC 0/5] Date Mode: Add --time-zone; deprecate --date=local Michael Witten
2011-04-20  2:45 ` [RFC 1/5] Light refactoring of date infrastructure Michael Witten
2011-04-20  2:45 ` [RFC 2/5] Pretty Print: show tz when using DATE_LOCAL Michael Witten
2011-04-21 22:34   ` Junio C Hamano
2011-04-22 14:08     ` Dates in Commits and other issues of style (Re: [RFC 2/5] Pretty Print: show tz when using DATE_LOCAL) Michael Witten
2011-04-25  1:26       ` Miles Bader
2011-04-25  3:57         ` Junio C Hamano
2011-04-25 10:45           ` Jakub Narebski
2011-04-25 18:29             ` Junio C Hamano
2011-04-22 14:36     ` [RFC 2/5] Pretty Print: show tz when using DATE_LOCAL Michael Witten
2011-04-22 15:06       ` Junio C Hamano
2011-04-20  2:45 ` [RFC 3/5] Date Mode: Implementation Michael Witten
2011-04-21 22:44   ` Junio C Hamano
2011-04-20  2:45 ` [RFC 4/5] Date Mode: Documentation Michael Witten
2011-04-20  2:45 ` [RFC 5/5] Date Mode: Tests Michael Witten
2011-04-21 22:44   ` Junio C Hamano
2011-04-23  3:42     ` Michael Witten
2011-04-23  5:06       ` Michael Witten
2011-04-23  3:45     ` Time zone option name (Re: [RFC 5/5] Date Mode: Tests) Michael Witten
2011-04-23  5:27       ` Junio C Hamano
2011-04-23  3:59   ` [RFC 5/5] Date Mode: Tests Michael Witten
2011-04-20  6:43 ` [RFC 0/5] Date Mode: Add --time-zone; deprecate --date=local Jeff King
2011-04-20 14:21   ` Michael Witten
2011-04-21  1:50     ` Junio C Hamano
2011-04-21  2:14       ` Michael Witten
2011-04-21  3:57         ` Junio C Hamano [this message]
2011-04-21  4:09           ` Michael Witten
2011-04-20 14:22   ` Michael Witten
2011-04-20 14:22   ` Michael Witten
2011-04-20 14:23   ` Michael Witten
2011-04-21  0:07     ` Tabs and spaces (Re: [RFC 0/5] Date Mode: Add --time-zone; deprecate --date=local) Jonathan Nieder
2011-04-21  1:51       ` Tabs and spaces Michael Witten
2011-04-21  2:18         ` Jonathan Nieder
2011-04-21  3:15           ` Michael Witten
2011-04-21  3:25             ` Thiago Farina
2011-04-21 10:46               ` Alex Riesen
2011-04-21 12:57                 ` Michael Witten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1v0wz26y.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mfwitten@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).