From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Makefile: extract Q_() source strings as ngettext()
Date: Mon, 11 Apr 2011 14:38:43 -0700 [thread overview]
Message-ID: <7v1v18v57g.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 20110410195436.GD28163@elie
Jonathan Nieder <jrnieder@gmail.com> writes:
> Ack. The line is getting long. Maybe it would make sense to split
> it up (like this)?
Makes sense, thanks both.
I've re-written the commit log message, by the way. Instead of saying "X
forgot to do Y and broke Z", I prefer to say "To make sure Z happens, we
need to do Y to augment what X did, and W is how we do Y".
prev parent reply other threads:[~2011-04-11 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-10 19:37 [PATCH] Makefile: extract Q_() source strings as ngettext() Ævar Arnfjörð Bjarmason
2011-04-10 19:54 ` Jonathan Nieder
2011-04-11 21:38 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1v18v57g.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).