From: Junio C Hamano <gitster@pobox.com>
To: Michael Witten <mfwitten@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC 1/3] Alternates API: Untangle the interface
Date: Wed, 30 Mar 2011 15:28:43 -0700 [thread overview]
Message-ID: <7v1v1omeec.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <5ed7886ec5e12c8e3a5f45d19625a4f5d2cdd38a.1301521243.git.mfwitten@gmail.com> (Michael Witten's message of "Wed, 30 Mar 2011 20:43:18 +0000")
Michael Witten <mfwitten@gmail.com> writes:
> diff --git a/transport.c b/transport.c
> index a02f79a..c61723f 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -1190,14 +1190,13 @@ literal_copy:
> return xstrdup(url);
> }
>
> -int refs_from_alternate_cb(struct alternate_object_database *e, void *cb)
> +int refs_from_alternate_cb(struct alternate_object_database *e, alternate_ref_fn ref_fn)
> {
Adding an extra "fn" is Ok, but I'd rather not to see removal of generic
callback data pointer if the _only_ reason you are doing so is "currently
nobody uses it".
Besides, I see "a function pointer and a data pointer cannot be held in a
single variable" as an academic mental mastu^wexercise that is useless in
real life. Are there real platforms that matter where (void *) cannot
hold a pointer to a function?
next prev parent reply other threads:[~2011-03-30 22:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 15:28 [RFC 2/2] Future Proofing: Pass around pointers to either functions or data Michael Witten
2011-03-29 15:02 ` [RFC 1/2] Portability: Convert strictly between function pointers Michael Witten
2011-03-30 10:09 ` [RFC 2/2] Future Proofing: Pass around pointers to either functions or data Erik Faye-Lund
2011-03-30 15:02 ` Michael Witten
2011-03-30 19:41 ` Junio C Hamano
2011-03-30 21:40 ` [RFC 0/3] Alternates API Michael Witten
2011-03-30 21:24 ` [RFC 2/3] Alternates API: Improve naming Michael Witten
2011-03-30 21:28 ` [RFC 3/3] Alternates API: Remove unused parameter Michael Witten
2011-03-30 20:43 ` [RFC 1/3] Alternates API: Untangle the interface Michael Witten
2011-03-30 22:28 ` Junio C Hamano [this message]
2011-03-30 22:46 ` [RFC 3/3] Alternates API: Remove unused parameter Junio C Hamano
2011-03-30 22:31 ` [RFC 2/3] Alternates API: Improve naming Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1v1omeec.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mfwitten@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).