From: Junio C Hamano <gitster@pobox.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: Erik Faye-Lund <kusmabite@gmail.com>,
Johannes Sixt <j6t@kdbg.org>,
git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: Q: does index-pack work in place on windows?
Date: Thu, 03 Feb 2011 17:59:48 -0800 [thread overview]
Message-ID: <7v1v3ozhij.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1102031958000.12104@xanadu.home> (Nicolas Pitre's message of "Thu\, 03 Feb 2011 20\:14\:34 -0500 \(EST\)")
Nicolas Pitre <nico@fluxnic.net> writes:
> On Wed, 2 Feb 2011, Junio C Hamano wrote:
>
>> I am trying to see if an index-pack with slight modification would be a
>> good replacement for verify-pack.
> ...
> index-pack _could_ be a replacement for verify-pack. It certainly can
> validate a pack since it is its purpose, possibly faster than
> verify-pack. You'd still have to compare the existing pack index
> against the one index-pack creates without overwriting that original
> index, taking into accound index version differences, etc.
We already know index-pack is a lot faster when you have a lot of deep
deltas, as it works from a base to its immediate delta children while
pinning that base, as opposed to verify-pack that verifies each and every
object in the pack in the index order, inflating and then applying
potentially long delta chains repeatedly---the only thing that could be
helping it right now is the in-core delta base cache.
> However index-pack won't tell you what is broken in the pack when
> corruptions are to be found.
Yes, but at that point, you are pretty much lost anyway, as the only thing
you can do to salvage salvageable parts of the broken pack, if you still
trust its associated .idx file, is to walk the table of contents and ask
for each individual object; knowing where the .pack or .idx is broken with
the current verify-pack does not help you very much.
next prev parent reply other threads:[~2011-02-04 2:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 20:21 Q: does index-pack work in place on windows? Junio C Hamano
2011-02-02 20:30 ` Erik Faye-Lund
2011-02-03 5:32 ` Nicolas Pitre
2011-02-03 7:24 ` Junio C Hamano
2011-02-04 1:14 ` Nicolas Pitre
2011-02-04 1:59 ` Junio C Hamano [this message]
2011-02-04 2:45 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1v3ozhij.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=kusmabite@gmail.com \
--cc=nico@fluxnic.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).