From: Junio C Hamano <gitster@pobox.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Robin Rosenberg" <robin.rosenberg@dewire.com>,
git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [minor BUG] cherry-pick -x doesn't work if a conflict occurs
Date: Wed, 05 Jan 2011 10:33:07 -0800 [thread overview]
Message-ID: <7v1v4rdwv0.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <AANLkTi==nMhcN538ekww3FEYFxhOqDqj4_Z7xg0a0B0Z@mail.gmail.com> (Jay Soffian's message of "Wed\, 5 Jan 2011 11\:37\:39 -0500")
Jay Soffian <jaysoffian@gmail.com> writes:
> Ah, seems to be a documented short-coming after-all:
>
> http://thread.gmane.org/gmane.comp.version-control.git/61737/focus=61933
Well, it is not.
Shawn might have accepted a documentation patch as such during my absence,
but when I originally wrote the "cherry-picked-from", it was a conscious
design decision not to carry the information forward in a conflicted case,
and the reasoning was exactly what you wrote in your first response.
Because -x has become an optional feature that a user has to explicitly
ask, I however tend to agree with Uwe that it may make sense to throw the
original commit object name in the commit log template these days. That
would allow the user to edit it further and say something like "Originally
done by Foo in commit 1234, forward ported with conflict resolution."
prev parent reply other threads:[~2011-01-05 18:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 14:16 [minor BUG] cherry-pick -x doesn't work if a conflict occurs Uwe Kleine-König
2011-01-05 6:31 ` Robin Rosenberg
2011-01-05 6:50 ` Uwe Kleine-König
2011-01-05 16:28 ` Jay Soffian
2011-01-05 16:37 ` Jay Soffian
2011-01-05 18:33 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1v4rdwv0.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
--cc=robin.rosenberg@dewire.com \
--cc=spearce@spearce.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).