From: Junio C Hamano <gitster@pobox.com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: Paul Drews <paul.drews@intel.com>, git@vger.kernel.org
Subject: Re: rebase not honoring core.worktree pointing elsewhere
Date: Mon, 01 Nov 2010 18:21:23 -0700 [thread overview]
Message-ID: <7v1v7434h8.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <AANLkTi=ejRcnz+83zc2Z-6etUGMsBSw1FFUY0JNFRFGB@mail.gmail.com> (Nguyen Thai Ngoc Duy's message of "Tue\, 2 Nov 2010 07\:11\:16 +0700")
Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
> Then, yes, rebase should be updated to use worktree even if it's
> outside cwd. I'm not sure how to do it properly in git-rebase.sh
> though. The requirement "require_work_tree" can be loosen a bit.
require-work-tree traditionally meant "you must be inside the working
tree, you could be in a subdirectory of it", but as long as the command is
about the whole tree operation (which rebase is) and takes no pathname
relative to the $(cwd) as an argument (which rebase does not), there is no
strong reason why you should be _inside_ the working tree. For such
commands, require-work-tree should mean "you must have a working tree, and
make it known where it is to git", nothing more.
next prev parent reply other threads:[~2010-11-02 1:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 17:22 rebase not honoring core.worktree pointing elsewhere Paul Drews
2010-11-01 17:38 ` Sverre Rabbelier
2010-11-02 0:11 ` Nguyen Thai Ngoc Duy
2010-11-02 1:21 ` Junio C Hamano [this message]
2010-11-02 16:26 ` Paul Drews
2010-11-03 0:13 ` Nguyen Thai Ngoc Duy
2010-11-03 15:41 ` Paul Drews
2010-11-03 15:52 ` Nguyen Thai Ngoc Duy
2010-11-03 16:13 ` Jonathan Nieder
2010-11-04 14:20 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1v7434h8.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=paul.drews@intel.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).