git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Jan Stępień" <jstepien@users.sourceforge.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fetch-pack: make the ssh connection quiet
Date: Wed, 27 Oct 2010 15:35:41 -0700	[thread overview]
Message-ID: <7v1v7bclhe.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 1288189628-4883-1-git-send-email-jstepien@users.sourceforge.net

Jan Stępień  <jstepien@users.sourceforge.net> writes:

> The --quiet option passed to fetch-pack did not affect the ssh child
> process. When an ssh server sent a motd it was displayed because the ssh
> client wasn't launched with the -q option.

This is curious for a couple of reasons:

1. "-q" option to "ssh" is not meant to supress "motd"; it is about
   warning and diagnostics.  From man ssh(1):

     -q Quiet mode.  Causes most warning and diagnostic messages to be
        suppressed.  Only fatal errors are displayed.  If a second -q is
        given then even fatal errors are suppressed, except for those
        produced due solely to bad argu‐ ments.

2. "PrintMotd" defaults to "yes" but it is to specify whether the daemon
   should print /etc/motd when a user logs in interactively.  I didn't
   think fetch-pack logged in interactively, so why should this matter?

  parent reply	other threads:[~2010-10-27 22:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-27 14:27 [PATCH] fetch-pack: make the ssh connection quiet Jan Stępień
2010-10-27 15:24 ` Drew Northup
2010-10-27 18:40   ` Jan Stępień
2010-10-27 22:35 ` Junio C Hamano [this message]
2010-10-28  9:14   ` Jan Stępień

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1v7bclhe.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jstepien@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).