git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: robbat2@gentoo.org, casey@nrlssc.navy.mil, git@vger.kernel.org,
	brian@gernhardtsoftware.com
Subject: Re: [PATCH/RFC] rev-parse: stop interpreting flags as options to rev-parse once --flags is specified
Date: Sun, 26 Sep 2010 00:11:54 -0700	[thread overview]
Message-ID: <7v1v8hnflx.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <AANLkTim0oxhgtgqbrqP-jDL29jj0y=h6BLssEAFzags9@mail.gmail.com> (Jon Seymour's message of "Sat\, 25 Sep 2010 17\:25\:16 +1000")

Jon Seymour <jon.seymour@gmail.com> writes:

> Mmmm...almost certainly not going to regress anything, since there
> does not seem to be a test or script that uses --flags. Ahem.

I've already explained the historical background in a separate message; I
realize that my message was missing the important part: conclusion.

If there weren't rev-parse before and we were about to invent the command,
I would agree that --flags should suppress output of HEAD.  Also I doubt
anybody relies on --flags for the purpose of removing non-revision
arguments.  So in that sense, your change would not hurt people.

But I do not think encouraging the use of rev-parse to pick "flags" is a
good idea in the longer term anyway, so I do not care too much about this
issue.  Unless you will teach "rev-parse --flags" about all the options
all other git command take (e.g. it should know --ignore-submodule takes
an optional option argument and be able to parse "--ignore-submodule all"
out), which is fundamentally impossible (e.g. for some commands "-n" does
not take argument, for some other "-n" takes an integer argument, and the
rev-parse command fundamentally cannot decide if it should report what
follows "-n" as part of its "--flags" output).

  reply	other threads:[~2010-09-26  7:21 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-24 19:19 git-1.7.3 breakage: "git stash show xxx" doesn't show anything Robin H. Johnson
2010-09-24 20:01 ` Brandon Casey
2010-09-24 20:27   ` Brian Gernhardt
2010-09-24 20:40     ` [PATCH] t/t3903-stash: improve testing of git-stash show Brandon Casey
2010-09-24 20:43       ` Brian Gernhardt
2010-09-24 20:50         ` Brandon Casey
2010-09-24 21:49           ` Brian Gernhardt
2010-09-24 22:11             ` [PATCH] git-stash: fix flag parsing Brian Gernhardt
2010-09-24 22:15             ` Brian Gernhardt
2010-09-25  2:58               ` Jon Seymour
2010-09-27  4:36               ` Junio C Hamano
2010-09-27 15:32                 ` [PATCH] stash: simplify parsing fixes Jon Seymour
2010-09-25  2:54 ` [PATCH] stash show: fix breakage in 1.7.3 Jon Seymour
2010-09-25  3:32 ` [PATCH v1] " Jon Seymour
2010-09-25  4:45   ` Brian Gernhardt
2010-09-25  6:19     ` Jon Seymour
2010-09-25  7:15   ` Jon Seymour
2010-09-27 15:38   ` Jon Seymour
2010-09-25  7:19 ` [PATCH/RFC] rev-parse: stop interpreting flags as options to rev-parse once --flags is specified Jon Seymour
2010-09-25  7:19   ` Jon Seymour
2010-09-25  7:25     ` Jon Seymour
2010-09-26  7:11       ` Junio C Hamano [this message]
2010-09-26 14:39         ` Jon Seymour
2010-09-26 14:44         ` [PATCH v7 0/3] rev-parse: allow --flags to output rev-parse-like flags Jon Seymour
2010-09-26 14:44         ` [PATCH v7 1/3] rev-parse: update Documentation of --flags Jon Seymour
2010-09-26 14:44         ` [PATCH v7 2/3] rev-parse: add tests for git rev-parse --flags Jon Seymour
2010-09-26 14:44         ` [PATCH v7 3/3] rev-parse: stop interpreting flags as options to rev-parse once --flags is specified Jon Seymour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1v8hnflx.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=brian@gernhardtsoftware.com \
    --cc=casey@nrlssc.navy.mil \
    --cc=git@vger.kernel.org \
    --cc=jon.seymour@gmail.com \
    --cc=robbat2@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).