From: Junio C Hamano <gitster@pobox.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] git-ls-files.txt: clarify -x/--exclude option
Date: Wed, 15 Sep 2010 17:41:52 -0700 [thread overview]
Message-ID: <7v1v8u5xkf.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1284595008-36464-1-git-send-email-jaysoffian@gmail.com> (Jay Soffian's message of "Wed\, 15 Sep 2010 19\:56\:48 -0400")
Jay Soffian <jaysoffian@gmail.com> writes:
> diff --git a/Documentation/git-ls-files.txt b/Documentation/git-ls-files.txt
> index 15aee2f..f52b06a 100644
> --- a/Documentation/git-ls-files.txt
> +++ b/Documentation/git-ls-files.txt
> @@ -79,8 +79,9 @@ OPTIONS
>
> -x <pattern>::
> --exclude=<pattern>::
> - Skips files matching pattern.
> - Note that pattern is a shell wildcard pattern.
> + Skips untracked files matching pattern.
> + Note that pattern is a shell wildcard pattern. See EXCLUDE PATTERNS
> + below for more information.
Would be helpful; will queue directly on top of 500348a.
Thanks
By the way, I think the language in that file needs a bit of tweaking for
readability. Perhaps this on top of your patch...
-- >8 --
Subject: [PATCH] ls-files documentation: reword for consistency
Similar to descriptions of other options, state what -x does in imperative
mood. Start sentences for -X and --exclude-per-directory options in
capital letters.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
Documentation/git-ls-files.txt | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/git-ls-files.txt b/Documentation/git-ls-files.txt
index c05e7a5..44b6480 100644
--- a/Documentation/git-ls-files.txt
+++ b/Documentation/git-ls-files.txt
@@ -79,16 +79,16 @@ OPTIONS
-x <pattern>::
--exclude=<pattern>::
- Skips untracked files matching pattern.
+ Skip untracked files matching pattern.
Note that pattern is a shell wildcard pattern. See EXCLUDE PATTERNS
below for more information.
-X <file>::
--exclude-from=<file>::
- exclude patterns are read from <file>; 1 per line.
+ Read exclude patterns from <file>; 1 per line.
--exclude-per-directory=<file>::
- read additional exclude patterns that apply only to the
+ Read additional exclude patterns that apply only to the
directory and its subdirectories in <file>.
--exclude-standard::
@@ -178,7 +178,7 @@ These exclude patterns come from these places, in order:
file containing a list of patterns. Patterns are ordered
in the same order they appear in the file.
- 3. command line flag --exclude-per-directory=<name> specifies
+ 3. The command line flag --exclude-per-directory=<name> specifies
a name of the file in each directory 'git-ls-files'
examines, normally `.gitignore`. Files in deeper
directories take precedence. Patterns are ordered in the
--
1.7.3.rc2.221.gbf93f
next prev parent reply other threads:[~2010-09-16 0:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 22:40 ls-files --exclude broken? Jay Soffian
2010-09-15 23:06 ` Nguyen Thai Ngoc Duy
2010-09-15 23:12 ` Junio C Hamano
2010-09-15 23:19 ` Jay Soffian
2010-09-15 23:29 ` Nguyen Thai Ngoc Duy
2010-09-15 23:41 ` Jay Soffian
2010-09-15 23:47 ` Jay Soffian
2010-09-16 0:16 ` Jeff King
2010-09-16 0:33 ` Jay Soffian
2010-09-16 0:50 ` Jeff King
2010-09-15 23:34 ` Elijah Newren
2010-09-15 23:21 ` Kevin Ballard
2010-09-15 23:31 ` Daniel Johnson
2010-09-15 23:56 ` [PATCH] git-ls-files.txt: clarify -x/--exclude option Jay Soffian
2010-09-16 0:19 ` Jeff King
2010-09-16 0:41 ` Junio C Hamano [this message]
2010-09-16 0:51 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1v8u5xkf.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).