git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] fetch: don't output non-errors on stderr
Date: Fri, 25 Jun 2010 14:43:27 -0700	[thread overview]
Message-ID: <7v1vbukcu8.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <AANLkTilToJ2ekKVgIeka5qx9_lasw6DKSy8bOhTrP4dC@mail.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri\, 25 Jun 2010 21\:28\:16 +0000")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> On Fri, Jun 25, 2010 at 17:25, Junio C Hamano <gitster@pobox.com> wrote:
>> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>
>>> Before the change error messages were drowned out by git-fetch's
>>> non-error update notices, which didn't need my attention.
>>
>> I don't understand this part; care to elaborate?
>
> I have a cron job (github-backup) that calls git fetch. Without this
> patch I have to run it as '> /dev/null 2>&1' and just rely on the exit
> code,

Signaling failure with exit code is _the_ standard practice, no?

Some people seem to think unclean standard error means some error (most
notably tcl ;-), but I think they are mistaken.

Not that I care too much about this issue, though.  I might end up queuing
it, but we need to think about things like advice messages and such
(e.g. 011fe98 (git-push: fix an advice message so it goes to stderr,
2010-02-26)).

  reply	other threads:[~2010-06-25 21:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-25 18:06 Bugreport: Git responds with stderr instead of stdout Jack Desert
2010-04-25 18:10 ` Jacob Helwig
2010-04-25 18:24   ` Ævar Arnfjörð Bjarmason
2010-04-25 19:22     ` Jeff King
2010-04-25 19:32       ` Ævar Arnfjörð Bjarmason
2010-04-25 19:32         ` Jeff King
2010-06-12 16:52           ` Ævar Arnfjörð Bjarmason
2010-06-24 22:34             ` [PATCH] fetch: don't output non-errors on stderr Ævar Arnfjörð Bjarmason
2010-06-25 13:30               ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2010-06-25 17:25               ` [PATCH] " Junio C Hamano
2010-06-25 21:28                 ` Ævar Arnfjörð Bjarmason
2010-06-25 21:43                   ` Junio C Hamano [this message]
2010-06-26  6:13                     ` Jeff King
2010-06-26 12:14                       ` Ævar Arnfjörð Bjarmason
2010-06-26 13:40                         ` Tay Ray Chuan
2010-06-26 15:07                           ` Ævar Arnfjörð Bjarmason
2010-06-26 16:46                         ` Jeff King
2010-06-26 16:50                           ` Ævar Arnfjörð Bjarmason
2010-04-25 18:34   ` Bugreport: Git responds with stderr instead of stdout Jack Desert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1vbukcu8.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).