From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Francois Marier <fmarier@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-archive documentation: .gitattributes must be committed
Date: Wed, 10 Feb 2010 11:27:50 -0800 [thread overview]
Message-ID: <7v1vgsao21.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4B7303FC.6070701@lsrfire.ath.cx> ("René Scharfe"'s message of "Wed\, 10 Feb 2010 20\:07\:40 +0100")
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
>> +The .gitattributes file must be present in the named tree for it to take
>> +effect. Uncommitted attributes will not be considered in exports.
>> +
>> EXAMPLES
>> --------
>> git archive --format=tar --prefix=junk/ HEAD | (cd /var/tmp/ && tar xf -)::
>
> Yeah, the description of --worktree-attributes is a bit terse. The
> lines you add make it appear almost as if this switch doesn't exist,
> though; perhaps add a "unless --worktree-attributes is given" or similar
> to one of the new sentences?
My impression has always been that people use attributes with archive more
often to _tweak_ how the archive is produced after the fact, and they do
so by modifying checked out .gitattributes (or $GIT_DIR/info/attributes)
than allowing a possibly stale .gitattributes file etched in stone^Wtree
being archived. So in that sense, probably --worktree-attributes should
have been the default.
By the way, if you commit the attributes file, then commit the removal of
that attributes file, would that removed attributes file take effect when
you archive HEAD^ (which still had the attribues file)? That's how I read
what the added description claims, but I somehow suspect that is not what
actually happens.
next prev parent reply other threads:[~2010-02-10 19:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 2:51 [PATCH] git-archive documentation: .gitattributes must be committed Francois Marier
2010-02-10 19:07 ` René Scharfe
2010-02-10 19:27 ` Junio C Hamano [this message]
2010-02-10 19:33 ` Junio C Hamano
2010-02-10 20:00 ` René Scharfe
2010-02-10 20:18 ` Junio C Hamano
2010-02-10 20:33 ` Junio C Hamano
2010-02-11 3:48 ` Francois Marier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1vgsao21.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=fmarier@gmail.com \
--cc=git@vger.kernel.org \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).