From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: <git@vger.kernel.org>,
Michael J Gruber <git@drmicha.warpmail.net>,
Ilari Liusvaara <ilari.liusvaara@elisanet.fi>,
Johannes Sixt <j.sixt@viscovery.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Documentation: improve description of --glob=pattern and friends
Date: Thu, 21 Jan 2010 16:51:06 -0800 [thread overview]
Message-ID: <7v1vhjj72d.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <e2e992cfb93335b400fd9ec67c6d38cb0157b006.1264119524.git.trast@student.ethz.ch> (Thomas Rast's message of "Fri\, 22 Jan 2010 01\:21\:38 +0100")
Thomas Rast <trast@student.ethz.ch> writes:
> Consolidate the descriptions of --branches, --tags and --remotes a
> bit, to make it less repetitive. Improve the grammar a bit, and spell
> out the meaning of the 'append /*' rule.
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
>
> Compared to the earlier draft, I changed "it is anchored" (by
> appending '/*') to "it is turned into a prefix match", since this is
> not anchoring in the ^regex$ sense. (I guess 'leading-component
> match' would be even more accurate, but that makes the sentence
> unwieldy in my ears.)
By the way, we may someday want to change that to do FNM_PATHNAME instead
of just a flat glob.
Incidentally, that is why I prefer the earlier suggestion to do "check
with memcmp() if it is a path-prefix, and if it fails, then give
fnmatch(FNM_PATHNAME) a chance". That way, we don't have to say "by
appending '/*'" (which is an implementation detail we can change).
It seems that the suggestion was ignored, though.
next prev parent reply other threads:[~2010-01-22 0:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 9:48 [PATCH 1/2] rev-parse --glob Ilari Liusvaara
2010-01-20 9:48 ` [PATCH 2/2] rev-parse --branches/--tags/--remotes=pattern Ilari Liusvaara
2010-01-20 10:18 ` Junio C Hamano
2010-01-21 12:51 ` Johannes Sixt
2010-01-21 13:51 ` Michael J Gruber
2010-01-21 17:27 ` Thomas Rast
2010-01-21 20:09 ` Junio C Hamano
2010-01-22 0:21 ` [PATCH] Documentation: improve description of --glob=pattern and friends Thomas Rast
2010-01-22 0:51 ` Junio C Hamano [this message]
2010-01-21 17:58 ` [PATCH 2/2] rev-parse --branches/--tags/--remotes=pattern Junio C Hamano
2010-01-20 10:17 ` [PATCH 1/2] rev-parse --glob Junio C Hamano
2010-01-20 11:08 ` Ilari Liusvaara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1vhjj72d.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=ilari.liusvaara@elisanet.fi \
--cc=j.sixt@viscovery.net \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).