git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Mark Blakeney <markb@berlios.de>, git@vger.kernel.org
Subject: Re: gitk does not show path file list
Date: Tue, 24 Nov 2009 00:11:11 -0800	[thread overview]
Message-ID: <7v1vjoibq8.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4B0B91DC.1020902@viscovery.net> (Johannes Sixt's message of "Tue\, 24 Nov 2009 08\:57\:16 +0100")

Johannes Sixt <j.sixt@viscovery.net> writes:

> Mark Blakeney schrieb:
>> This seems to me to be a straight out bug but given I've had no response here
>> and  given this is such a simple issue then I guess it's not a bug and I'm just
>> missing something? Please somebody, why does gitk (usually) not show the subset
>> list of files affected when you give it a path?
>> 
>> E.g. If I am in a src dir then "gitk ." does not list files. Neither does "gitk
>> $PWD" nor "gitk ../src". However "cd ..; git src" does list files!?
>
> gitk doesn't list the files in your examples because the patterns you gave
> are not initial substrings of any files in the list.

Yes, but if you are in src/ and run "gitk .", then...

 - clicking on a commit runs "diff-tree $commit .", that lists
   src/hello.c, src/goodbye.c, etc.

 - gitk tries to filter paths read from diff-tree with the "." given from
   the command line as the filter---it removes paths that do not match.

So the only case that would produce any output would be for you to have:

 src/src/hello.c
 src/frotz.c

and run

 cd src && gitk src

whose invocation of "diff-tree src" will show _only_ src/src/hello.c and
then the filter procedure will limit it to whatever begins with src/
(which would be everything).

That does not sound very useful to me...

   

      reply	other threads:[~2009-11-24  8:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-17 12:09 gitk does not show path file list Mark Blakeney
2009-11-24  5:36 ` Mark Blakeney
2009-11-24  7:22   ` Junio C Hamano
2009-11-24  7:57   ` Johannes Sixt
2009-11-24  8:11     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1vjoibq8.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=j.sixt@viscovery.net \
    --cc=markb@berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).