git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Philippe Bruhat \(BooK\)" <book@cpan.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Make sure $PERL_PATH is defined when the test suite is run.
Date: Mon, 16 Nov 2009 16:10:13 -0800	[thread overview]
Message-ID: <7v1vjym2oq.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1258415600-4656-1-git-send-email-book@cpan.org> (Philippe Bruhat's message of "Tue\, 17 Nov 2009 00\:53\:20 +0100")

"Philippe Bruhat (BooK)" <book@cpan.org> writes:

> diff --git a/t/t9400-git-cvsserver-server.sh b/t/t9400-git-cvsserver-server.sh
> index 64f947d..dc710f8 100755
> --- a/t/t9400-git-cvsserver-server.sh
> +++ b/t/t9400-git-cvsserver-server.sh
> @@ -20,7 +20,7 @@ then
>      say 'skipping git-cvsserver tests, cvs not found'
>      test_done
>  fi
> -perl -e 'use DBI; use DBD::SQLite' >/dev/null 2>&1 || {
> +$PERL_PATH -e 'use DBI; use DBD::SQLite' >/dev/null 2>&1 || {
>      say 'skipping git-cvsserver tests, Perl SQLite interface unavailable'
>      test_done
>  }

Shouldn't these $PERL_PATH all be quoted inside double-quotes?

  reply	other threads:[~2009-11-17  0:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10 10:46 [PATCH] Define $PERL_PATH in test-lib.sh Philippe Bruhat (BooK)
2009-11-10 12:23 ` Jeff King
2009-11-10 13:33   ` Philippe Bruhat (BooK)
2009-11-15  9:12   ` Junio C Hamano
2009-11-16 23:48     ` Philippe Bruhat (BooK)
2009-11-16 23:53       ` [PATCH] Make sure $PERL_PATH is defined when the test suite is run Philippe Bruhat (BooK)
2009-11-17  0:10         ` Junio C Hamano [this message]
2009-11-17  0:17           ` Philippe Bruhat (BooK)
2009-11-17  0:20           ` Philippe Bruhat (BooK)
2009-11-17  8:30             ` Johannes Sixt
2009-11-17  8:35               ` Philippe Bruhat (BooK)
2009-11-17 18:25                 ` Junio C Hamano
2009-11-17  8:42               ` Philippe Bruhat (BooK)
2009-11-10 12:26 ` [PATCH] Define $PERL_PATH in test-lib.sh Johannes Sixt
2009-11-10 13:34   ` Philippe Bruhat (BooK)
2009-11-10 20:17     ` Junio C Hamano
2009-11-11  8:40       ` Philippe Bruhat (BooK)
2009-11-11  8:43         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1vjym2oq.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=book@cpan.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).