From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Scott Chacon <schacon@gmail.com>, git list <git@vger.kernel.org>
Subject: Re: [PATCH] Update packfile transfer protocol documentation
Date: Tue, 03 Nov 2009 17:48:36 -0800 [thread overview]
Message-ID: <7v1vkfnjpn.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20091104011802.GE10505@spearce.org> (Shawn O. Pearce's message of "Tue\, 3 Nov 2009 17\:18\:03 -0800")
"Shawn O. Pearce" <spearce@spearce.org> writes:
> Junio C Hamano <gitster@pobox.com> wrote:
>> "Shawn O. Pearce" <spearce@spearce.org> writes:
>> > I don't think we ever send an empty packet. If we have no data to
>> > send, why the hell did we create the packet header?
>>
>> Oh, I do not disagree that it is pointless, but the example that followed
>> the part we are discussing also had "0004". I think it is Ok to allow it.
>
> If its pointless, why encourage it? Why not discourage it with SHOULD NOT?
Oh, no, I didn't mean to _encourage_ it.
I just thought that it being pointless at the semantic level would already
be an enough discouragement for people who are intelligent enough.
As I said, this was not an objection to start with.
> Sure, but can't packet_write just return early without write()
> if format_packet returned 4 (aka vsnprintf returned 0)?
Ah, that's right.
next prev parent reply other threads:[~2009-11-04 1:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-01 23:18 [PATCH] Update packfile transfer protocol documentation Scott Chacon
2009-11-02 5:17 ` Junio C Hamano
2009-11-02 15:41 ` Shawn O. Pearce
2009-11-02 17:31 ` Junio C Hamano
2009-11-02 15:43 ` Shawn O. Pearce
2009-11-02 23:48 ` Junio C Hamano
2009-11-02 23:57 ` Shawn O. Pearce
2009-11-03 0:36 ` Junio C Hamano
2009-11-03 0:58 ` Shawn O. Pearce
2009-11-03 22:05 ` Scott Chacon
2009-11-04 0:40 ` Junio C Hamano
2009-11-04 0:40 ` Junio C Hamano
2009-11-04 0:56 ` Shawn O. Pearce
2009-11-04 1:07 ` Junio C Hamano
2009-11-04 1:18 ` Shawn O. Pearce
2009-11-04 1:48 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-11-04 5:58 Scott Chacon
2009-11-04 6:36 ` Sverre Rabbelier
2009-11-05 5:24 ` Junio C Hamano
2009-10-29 17:35 Scott Chacon
2009-10-30 22:07 ` Junio C Hamano
2009-10-31 2:06 ` Shawn O. Pearce
2009-10-31 20:12 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1vkfnjpn.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=schacon@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).