From: Junio C Hamano <gitster@pobox.com>
To: Sean Estabrooks <seanlkml@sympatico.ca>
Cc: Thomas Rast <trast@student.ethz.ch>, <git@vger.kernel.org>
Subject: Re: [PATCH] pull: refuse complete src:dst fetchspec arguments
Date: Tue, 20 Oct 2009 14:11:06 -0700 [thread overview]
Message-ID: <7v1vkxn53p.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <BLU0-SMTP97AA2287062D9A104101C8AEC00@phx.gbl> (Sean Estabrooks's message of "Tue\, 20 Oct 2009 13\:30\:53 -0700")
Sean Estabrooks <seanlkml@sympatico.ca> writes:
>> -test_expect_success 'pulling into void using master:master' '
>> - mkdir cloned-uho &&
>> - (
>> - cd cloned-uho &&
>> - git init &&
>> - git pull .. master:master
>> - ) &&
>> - test -f file &&
>> - test -f cloned-uho/file &&
>> - test_cmp file cloned-uho/file
>> -
>> -
>> test_expect_success 'test . as a remote' '
>>
>> git branch copy master &&
>> --
>>
>
> Instead of removing this test it should be modified or replaced
> with a test that ensures the new functionality operates correctly.
> In this case that would mean checking that using a full refspec
> errors out.
Shouldn't "git pull .. master" still work in this case, too? So this test
will probably become two tests, one for "git pull .. master:master" that
correctly fails, and the other for "git pull .. master" to still work as
expected.
next prev parent reply other threads:[~2009-10-20 21:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 18:23 [PATCH] pull: refuse complete src:dst fetchspec arguments Thomas Rast
2009-10-20 18:37 ` [RFC! PATCH] " Thomas Rast
2009-10-20 19:29 ` [PATCH] " Wesley J. Landaker
2009-10-20 20:30 ` Sean Estabrooks
2009-10-20 21:11 ` Junio C Hamano [this message]
2009-10-21 0:15 ` Daniel Barkalow
2009-10-21 0:29 ` Sean Estabrooks
2009-10-21 0:55 ` Daniel Barkalow
2009-10-21 1:35 ` Sean Estabrooks
2009-10-21 3:15 ` Björn Steinbrink
2009-10-21 4:32 ` Daniel Barkalow
2009-10-21 8:05 ` Thomas Rast
2009-10-23 2:54 ` Jeff King
2009-10-23 3:43 ` Daniel Barkalow
2009-10-24 0:49 ` Jeff King
2009-10-24 1:22 ` Junio C Hamano
2009-10-21 8:06 ` Thomas Rast
2009-11-15 12:24 ` Thomas Rast
2009-11-15 20:22 ` Junio C Hamano
2009-12-29 11:05 ` Nanako Shiraishi
2009-12-29 16:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1vkxn53p.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=seanlkml@sympatico.ca \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).