From: Junio C Hamano <gitster@pobox.com>
To: Steffen Prohaska <prohaska@zib.de>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Git Mailing List <git@vger.kernel.org>,
Johannes Sixt <johannes.sixt@telecom.at>,
Steve Haslam <shaslam@lastminute.com>
Subject: Re: [PATCH 3/6] Glean libexec path from argv[0] for git-upload-pack and git-receive-pack.
Date: Sun, 11 Jan 2009 02:21:35 -0800 [thread overview]
Message-ID: <7v1vvata6o.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <E976B246-AD14-4B03-B204-F6A1014071DF@zib.de> (Steffen Prohaska's message of "Sun, 11 Jan 2009 11:04:23 +0100")
Steffen Prohaska <prohaska@zib.de> writes:
>> Hmm, I actually was thinking about applying that (and that one only)
>> early
>> to my tree, to make sure it is regression-free.
>
> Does "early" mean that you want to wait and see how the discussion
> about the other patches evolves before you consider applying them,
> or does "and that one only" mean that you tend to not apply the
> other patches at all?
My initial impression after reading 1/6 was that no matter how the actual
runtime prefix detection logic that is implemented in the later parts of
the series for particular platform will turn out to be, the update to the
Makefile that is done by 1/6 won't have to change. If I apply 1/6 first
without applying anything else, we can make sure that it would not regress
for Unix people (and catch regressions early if any), while Windows people
polish the platform specific parts of the implementation in the later
parts of the series that can be replaced.
Because changes to Makefile variables tend to have unexpected side effects
(people have their own definition to override them in their build
procedures and you can easily break them unless you are careful), I wanted
to make sure the common part is solid before waiting for the other part.
But if you think it is better not to apply any one, until other parts
mature, it is Ok by me, too.
next prev parent reply other threads:[~2009-01-11 10:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 13:50 [PATCH 1/6] Move computation of absolute paths from Makefile to runtime and compute prefix on the fly if RUNTIME_PREFIX set Steffen Prohaska
2009-01-10 13:50 ` [PATCH 2/6] Refactor git_set_argv0_path() to git_extract_argv0_path() Steffen Prohaska
2009-01-10 13:50 ` [PATCH 3/6] Glean libexec path from argv[0] for git-upload-pack and git-receive-pack Steffen Prohaska
2009-01-10 13:50 ` [PATCH 4/6] Add calls to git_extract_argv0_path() in programs that call git_config_* Steffen Prohaska
2009-01-10 13:50 ` [PATCH 5/6] Modify setup_path() to only add git_exec_path() to PATH Steffen Prohaska
2009-01-10 13:50 ` [PATCH 6/6] Windows: Revert to default paths and convert them by RUNTIME_PREFIX Steffen Prohaska
2009-01-10 14:34 ` [PATCH 3/6] Glean libexec path from argv[0] for git-upload-pack and git-receive-pack Johannes Schindelin
2009-01-10 15:55 ` Steffen Prohaska
2009-01-10 16:01 ` Steffen Prohaska
2009-01-10 20:36 ` Junio C Hamano
2009-01-11 10:04 ` Steffen Prohaska
2009-01-11 10:21 ` Junio C Hamano [this message]
2009-01-11 12:57 ` Steffen Prohaska
2009-01-13 19:36 ` Johannes Sixt
2009-01-13 19:37 ` [PATCH 2/6] Refactor git_set_argv0_path() to git_extract_argv0_path() Johannes Sixt
2009-01-13 19:43 ` [PATCH 1/6] Move computation of absolute paths from Makefile to runtime and compute prefix on the fly if RUNTIME_PREFIX set Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1vvata6o.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=johannes.sixt@telecom.at \
--cc=prohaska@zib.de \
--cc=shaslam@lastminute.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).