From: Junio C Hamano <gitster@pobox.com>
To: mkoegler@auto.tuwien.ac.at (Martin Koegler)
Cc: Nicolas Pitre <nico@cam.org>, Simon Hausmann <simon@lst.de>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: git fsck segmentation fault
Date: Wed, 10 Dec 2008 22:42:40 -0800 [thread overview]
Message-ID: <7v1vwfw6u7.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20081211062753.GA17683@auto.tuwien.ac.at> (Martin Koegler's message of "Thu, 11 Dec 2008 07:27:53 +0100")
mkoegler@auto.tuwien.ac.at (Martin Koegler) writes:
> fsck_walk has been designed to call a function on all directly
> connected objected. There are callers, which expected this behaviour
> (eg. index-pack, mark_used in fsck).
Yes, that is where my "initially expected" comes from. I was not
complaining or suggesting the behaviour to change.
I was fooled by the word *walk* in the name, which implies an
implementation of walking connectivity fully, with or without an ability
for the callback to tell the machinery when to or not to dig deeper. It
wouldn't have been confusing if it were named "fsck_step()", which is what
the function is about: performing a single step of digging deeper.
prev parent reply other threads:[~2008-12-11 6:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 17:14 git fsck segmentation fault Simon Hausmann
2008-11-27 17:47 ` Nicolas Pitre
2008-11-27 19:10 ` Simon Hausmann
2008-11-27 19:21 ` Simon Hausmann
2008-11-27 19:57 ` Nicolas Pitre
2008-11-28 8:19 ` Simon Hausmann
2008-12-09 19:09 ` Nicolas Pitre
2008-12-09 21:57 ` Martin Koegler
2008-12-10 7:53 ` Martin Koegler
2008-12-11 2:33 ` Junio C Hamano
2008-12-11 6:27 ` Martin Koegler
2008-12-11 6:42 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1vwfw6u7.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mkoegler@auto.tuwien.ac.at \
--cc=nico@cam.org \
--cc=simon@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).