From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
git@vger.kernel.org, Petr Baudis <pasky@ucw.cz>,
Lea Wiemann <lewiemann@gmail.com>
Subject: Re: [PATCH v7, resend] gitweb: ref markers link to named shortlogs
Date: Tue, 02 Sep 2008 16:26:54 -0700 [thread overview]
Message-ID: <7v1w02i0xt.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200809030116.13676.jnareb@gmail.com> (Jakub Narebski's message of "Wed, 3 Sep 2008 01:16:12 +0200")
Jakub Narebski <jnareb@gmail.com> writes:
> On Tue, 2 Sep 2008, Giuseppe Bilotta wrote:
>
>> This patch turns ref markers for tags and heads into links to
>> appropriate views for the ref name, depending on current context.
>>
>> For annotated tags, we link to the tag view, unless that's the current
>> view, in which case we switch to shortlog. For other refs, we prefer the
>> current view if it's history or (short)log, and default to shortlog
>> otherwise.
>>
>> Appropriate changes are made in the CSS to prevent ref markers from
>> being annoyingly blue and underlined, unless hovered. A visual
>> indication of the target view difference is also implemented by making
>> annotated tags show up in italic.
>>
>> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
>
> Acked-by: Jakub Narebski <jnareb@gmail.com>
Thanks (and thanks, Pasky, too). Will apply.
next prev parent reply other threads:[~2008-09-02 23:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 19:47 [PATCH v7, resend] gitweb: ref markers link to named shortlogs Giuseppe Bilotta
2008-09-02 21:15 ` Petr Baudis
2008-09-02 23:16 ` Jakub Narebski
2008-09-02 23:26 ` Junio C Hamano [this message]
2008-09-02 23:55 ` Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1w02i0xt.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=jnareb@gmail.com \
--cc=lewiemann@gmail.com \
--cc=pasky@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).