From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <johannes.sixt@telecom.at>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH 5/9 v2] Allow the built-in exec path to be relative to the command invocation path
Date: Sun, 27 Jul 2008 23:42:30 -0700 [thread overview]
Message-ID: <7v1w1ev7ah.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7v3aly5zz3.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Thu, 24 Jul 2008 21:50:40 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Johannes Sixt <johannes.sixt@telecom.at> writes:
>
>> On Donnerstag, 24. Juli 2008, Junio C Hamano wrote:
>>> Johannes Sixt <johannes.sixt@telecom.at> writes:
>>> > It also fixes 'make install' of git-gui as well (sigh!) by not exporting
>>> > gitexecdir - assuming that Shawn applies the git-gui patch.
>>>
>>> Yeah, this seems to break the install quite badly without git-gui patch.
>>
>> If you squash this in, we don't need the git-gui patch.
>
> Thanks.
>
> I think this patch makes _more_ sense than the git-gui patch, actually.
>
> Within the context of git.git project, we would want to force the
> installation directory of git-gui portion to be consistent with the main
> project.
What I wanted to say with the above is that the main Makefile is what has
its own special need from git-gui/Makefile's point of view, so passing
such customization from the main Makefile makes a lot of sense.
I think this is also needed; I noticed it while trying the "build on a
machine without any git installed" exercise.
diff --git a/Makefile b/Makefile
index 798a2f2..52c67c1 100644
--- a/Makefile
+++ b/Makefile
@@ -1067,7 +1067,7 @@ endif
all::
ifndef NO_TCLTK
- $(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) all
+ $(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) gitexecdir='$(gitexec_instdir_SQ)' all
$(QUIET_SUBDIR0)gitk-git $(QUIET_SUBDIR1) all
endif
$(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' all
next prev parent reply other threads:[~2008-07-28 6:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 19:19 [PATCH 0/9] Make gitexecdir relative to $(bindir) on Windows Johannes Sixt
2008-07-21 19:19 ` [PATCH 1/9] Makefile: Do not install a copy of 'git' in $(gitexecdir) Johannes Sixt
2008-07-21 19:19 ` [PATCH 2/9] Makefile: Normalize $(bindir) and $(gitexecdir) before comparing Johannes Sixt
2008-07-21 19:19 ` [PATCH 3/9] Record the command invocation path early Johannes Sixt
2008-07-21 19:19 ` [PATCH 4/9] Fix relative built-in paths to be relative to the command invocation Johannes Sixt
2008-07-21 19:19 ` [PATCH 5/9] Allow the built-in exec path to be relative to the command invocation path Johannes Sixt
2008-07-21 19:19 ` [PATCH 6/9] Allow add_path() to add non-existent directories to the path Johannes Sixt
2008-07-21 19:19 ` [PATCH 7/9] Windows: Make $(gitexecdir) relative Johannes Sixt
2008-07-21 19:19 ` [PATCH 8/9] Windows: Make sure argv[0] has a path Johannes Sixt
2008-07-21 19:19 ` [PATCH 9/9] Windows: Do not compile git-shell Johannes Sixt
2008-07-21 19:26 ` [PATCH 10/9] git-gui: git.git now uses $(gitexec_instdir) to point to the exec-path Johannes Sixt
2008-07-25 4:43 ` [PATCH 9/9] Windows: Do not compile git-shell Steffen Prohaska
2008-07-23 18:31 ` [PATCH 5/9] Allow the built-in exec path to be relative to the command invocation path Junio C Hamano
2008-07-23 19:12 ` [PATCH 5/9 v2] " Johannes Sixt
2008-07-24 4:21 ` Junio C Hamano
2008-07-24 19:24 ` Johannes Sixt
2008-07-25 4:50 ` Junio C Hamano
2008-07-25 8:32 ` Johannes Sixt
2008-07-25 8:38 ` Johannes Sixt
2008-07-28 6:42 ` Junio C Hamano [this message]
2008-07-21 23:48 ` [PATCH 2/9] Makefile: Normalize $(bindir) and $(gitexecdir) before comparing Johannes Schindelin
2008-07-22 7:25 ` Johannes Sixt
2008-07-28 0:18 ` [PATCH 1/9] Makefile: Do not install a copy of 'git' in $(gitexecdir) A Large Angry SCM
2008-07-28 6:24 ` Junio C Hamano
2008-07-28 6:39 ` Junio C Hamano
2008-07-28 10:43 ` A Large Angry SCM
2008-07-28 23:13 ` A Large Angry SCM
2008-07-28 10:41 ` A Large Angry SCM
2008-07-21 23:45 ` [PATCH 0/9] Make gitexecdir relative to $(bindir) on Windows Johannes Schindelin
2008-07-22 19:31 ` Johannes Sixt
2008-07-23 18:28 ` Junio C Hamano
2008-07-23 18:49 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1w1ev7ah.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johannes.sixt@telecom.at \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).