From: Junio C Hamano <gitster@pobox.com>
To: Pavel Roskin <proski@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t9600: allow testing with cvsps 2.2, including beta versions
Date: Mon, 14 Jul 2008 17:31:40 -0700 [thread overview]
Message-ID: <7v1w1wdm37.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080715002019.5337.81984.stgit@dv.roinet.com> (Pavel Roskin's message of "Mon, 14 Jul 2008 20:20:19 -0400")
Pavel Roskin <proski@gnu.org> writes:
> Don't assume that unsupported versions are too old, they may be too new.
Excuse me, but we never assumed such.
Neither too old nor too new ones are proven to work with us yet, so we
cannot be call them supported.
Let's apply your patch and see how well version 2.2 fares.
Thanks.
> diff --git a/t/t9600-cvsimport.sh b/t/t9600-cvsimport.sh
> index 655f882..f92b47a 100755
> --- a/t/t9600-cvsimport.sh
> +++ b/t/t9600-cvsimport.sh
> @@ -20,13 +20,15 @@ cvsps_version=`cvsps -h 2>&1 | sed -ne 's/cvsps version //p'`
> case "$cvsps_version" in
> 2.1)
> ;;
> +2.2*)
> + ;;
Hmm, I would have written:
case "$..." in
2.1 | 2.2 )
Is the reason why you have the asterisk there because the beta one claims
"2.2beta" or something (I am not suggesting to tighten the match, just
asking for information)?
next prev parent reply other threads:[~2008-07-15 0:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-15 0:20 [PATCH] t9600: allow testing with cvsps 2.2, including beta versions Pavel Roskin
2008-07-15 0:31 ` Junio C Hamano [this message]
2008-07-15 0:51 ` Pavel Roskin
2008-07-16 7:11 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1w1wdm37.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).