git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Teemu Likonen <tlikonen@iki.fi>
Cc: Adam Simpkins <adam@adamsimpkins.net>, git@vger.kernel.org
Subject: Re: log --graph --first-parent weirdness
Date: Wed, 04 Jun 2008 11:05:38 -0700	[thread overview]
Message-ID: <7v1w3dxeh9.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080604173820.GA3038@mithlond.arda.local> (Teemu Likonen's message of "Wed, 4 Jun 2008 20:38:20 +0300")

Teemu Likonen <tlikonen@iki.fi> writes:

> To me it's perfectly fine to turn off --graph when used with
> --first-parent, but yes, generally users might expect to see a line of
> M's, *'s and |'s there. At least it would clearly show which commits are
> merges and which are not.

I disagree.  If you are doing --first-parent, you do not _care_ what is
merge and what is not.  Besides, you can easily see that from the log
message if you cared enough.

And if the graph actually draws the real ancestry graph (i.e. without
--first-parent), the lines visually show which is merge and which is not,
so the "M" gets very distracting.

I'd really suggest changing the "M" and use "*" everywhere.

  parent reply	other threads:[~2008-06-04 18:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04 15:00 log --graph --first-parent weirdness Teemu Likonen
2008-06-04 15:08 ` Teemu Likonen
2008-06-04 17:12 ` Junio C Hamano
2008-06-04 17:38   ` Teemu Likonen
2008-06-04 18:04     ` Adam Simpkins
2008-06-05  8:56       ` [PATCH] graph API: fix "git log --graph --first-parent" Adam Simpkins
2008-06-04 18:05     ` Junio C Hamano [this message]
2008-06-05  1:37       ` log --graph --first-parent weirdness Ping Yin
2008-06-05  9:28       ` Adam Simpkins
2008-06-05  9:50       ` Teemu Likonen
2008-06-05 18:31         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1w3dxeh9.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=adam@adamsimpkins.net \
    --cc=git@vger.kernel.org \
    --cc=tlikonen@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).