git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junio@pobox.com>
To: Ping Yin <pkufranky@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH/RFC 3/7] git-submodule: Fall back on .gitmodules if info not found in $GIT_DIR/config
Date: Fri, 11 Apr 2008 16:24:49 -0700	[thread overview]
Message-ID: <7v1w5cotz2.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1207842625-9210-7-git-send-email-pkufranky@gmail.com> (Ping Yin's message of "Thu, 10 Apr 2008 23:50:21 +0800")

Ping Yin <pkufranky@gmail.com> writes:

> Originally, the submodule workflow enforces 'git init' in the beginning
> which copies submodule config info from .gitmodules to $GIT_DIR/config.
> Then all subcommands except 'init' and 'add' fetch submodule info from
> $GIT_DIR/config and .gitmodules can be discarded.
>
> However, there may be inconsistence between .git/config and .gitmodules
> when always using 'git init' at first. If upstream .gitmodules changes,
> it is not easy to sync the changes to $GIT_DIR/config.

Maybe you missed an earlier thread with Roman Shaposhnik where this issue
was discussed and a solution more in line with the original intent of the
design of the submodule system was mentioned (actually I should not take
credit for that suggestion as it was not mine but somebody else mentioned
it back when git-submodule command was initially being designed.  I only
recalled there was that one issue in the old discussion but there might
have been others)?

  parent reply	other threads:[~2008-04-11 23:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-10 15:50 [PATCH/RFC] submodule: fallback to .gitmodules and multiple level module definition Ping Yin
2008-04-10 15:50 ` [PATCH/RFC 1/7] git-submodule: Extract functions module_info and module_url Ping Yin
2008-04-10 15:50   ` [PATCH v2 1/3] git-submodule summary: --for-status option Ping Yin
2008-04-10 15:50     ` [PATCH v2 2/3] builtin-status: submodule summary support Ping Yin
2008-04-10 15:50       ` [PATCH/RFC 2/7] git-submodule: Extract absolute_url & move absolute url logic to module_clone Ping Yin
2008-04-10 15:50         ` [PATCH v2 3/3] buitin-status: Add tests for submodule summary Ping Yin
2008-04-10 15:50           ` [PATCH/RFC 3/7] git-submodule: Fall back on .gitmodules if info not found in $GIT_DIR/config Ping Yin
2008-04-10 15:50             ` [PATCH/RFC 4/7] git-submodule: Extract module_add from cmd_add Ping Yin
2008-04-10 15:50               ` [PATCH/RFC 5/7] git-submodule: multi-level module definition Ping Yin
2008-04-10 15:50                 ` [PATCH/RFC 6/7] git-submodule: Don't die when command fails for one submodule Ping Yin
2008-04-10 15:50                   ` [PATCH/RFC 7/7] git-submodule: "update --force" to enforce cloning non-submodule Ping Yin
2008-04-11 23:24             ` [PATCH/RFC 3/7] git-submodule: Fall back on .gitmodules if info not found in $GIT_DIR/config Junio C Hamano
2008-04-11 23:24             ` Junio C Hamano [this message]
2008-04-12  4:26               ` Ping Yin
2008-04-11 21:56         ` [PATCH/RFC 2/7] git-submodule: Extract absolute_url & move absolute url logic to module_clone Junio C Hamano
2008-04-12  2:56           ` Ping Yin
2008-04-10 15:57     ` [PATCH v2 1/3] git-submodule summary: --for-status option Ping Yin
2008-04-11 22:30   ` [PATCH/RFC 1/7] git-submodule: Extract functions module_info and module_url Junio C Hamano
2008-04-12  3:05     ` Ping Yin
2008-04-12  4:50       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1w5cotz2.fsf@gitster.siamese.dyndns.org \
    --to=junio@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pkufranky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).