From: Junio C Hamano <gitster@pobox.com>
To: "Rhodes, Kate" <masukomi@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Specified the expected formats of dates and timestamps in rev-list-options.
Date: Mon, 10 Mar 2008 23:48:22 -0700 [thread overview]
Message-ID: <7v1w6heoy1.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <FC7C7E68-1D91-4719-9D11-8F65DEA43AFB@gmail.com> (Kate Rhodes's message of "Mon, 10 Mar 2008 23:41:48 -0400")
"Rhodes, Kate" <masukomi@gmail.com> writes:
> The docs didn't give users any indication of the expected format of
> dates or timestamps. Now they do.
>
> ---
Please look at other commits and follow the examples. Even though you are
describing what you did in the past, the title line do not use past tense
(e.g. "Distimmed doshes"), but imperative mood (e.g. "Distim doshes").
Sign your patch.
> --since='date', --after='date'::
>
> - Show commits more recent than a specific date.
> + Show commits more recent than a date specified relatively
> + (e.g. "2 hours ago") or with any ISO 8601 or RFC 2822
> + date syntax.
>
> --until='date', --before='date'::
>
> - Show commits older than a specific date.
> + Show commits older than a date specified relatively (e.g.
> + "2 hours ago") or with any ISO 8601 or RFC 2822 date syntax.
>
s/any //;
How about giving a few examples after this entry instead?
> --max-age='timestamp', --min-age='timestamp'::
>
> Limit the commits output to specified time range.
> + The 'timestamp' should be the interger seconds since the epoch.
"the number of seconds since the epoch".
> --author='pattern', --committer='pattern'::
>
> --
> 1.5.4.1.1278.gc75be
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-03-11 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-11 3:41 [PATCH] Specified the expected formats of dates and timestamps in rev-list-options Rhodes, Kate
2008-03-11 6:48 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1w6heoy1.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=masukomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).