git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Martin Langhoff <martin@catalyst.net.nz>,
	Robin Rosenberg <robin.rosenberg@dewire.com>
Subject: Re: [PATCH] cvsexportcommit: be graceful when "cvs status" reorders the arguments
Date: Mon, 18 Feb 2008 10:36:59 -0800	[thread overview]
Message-ID: <7v1w7ap0vo.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: alpine.LSU.1.00.0802181627340.30505@racer.site

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> The script uses File::Basename upfront so perhaps just simply...
>
> I tried that.  But as the file need not exist, "basename" went on strike.
>
> So I'll keep the (ugly) version.

The reason why "basename" is not being used needs documented in
the code then.  The next person will likely to make the same
mistake as I did.

  reply	other threads:[~2008-02-18 18:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18  1:31 [PATCH] cvsexportcommit: be graceful when "cvs status" reorders the arguments Johannes Schindelin
2008-02-18  3:03 ` Junio C Hamano
2008-02-18  3:20   ` Junio C Hamano
2008-02-18 15:25     ` Martin Langhoff
2008-02-18 16:27       ` Johannes Schindelin
2008-02-18 16:33         ` Martin Langhoff
2008-02-18 17:43           ` Johannes Schindelin
2008-02-18 17:55           ` [PATCH v2] " Johannes Schindelin
2008-02-18 17:54   ` [PATCH] " Johannes Schindelin
2008-02-18 18:36     ` Junio C Hamano [this message]
2008-02-18 18:50       ` Johannes Schindelin
2008-02-18 18:55       ` Martin Langhoff
2008-02-18 19:42         ` Johannes Schindelin
2008-02-18 20:06           ` Martin Langhoff
2008-02-18 20:29             ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1w7ap0vo.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=martin@catalyst.net.nz \
    --cc=robin.rosenberg@dewire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).